Re: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS

[Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2672 bytes --]

Hi, Sergey!

Thanks for the patch! LGTM.

--
Best regards,
Evgeniy Temirgaleev

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Sergey Bronnikov <sergeyb@tarantool.org>, Evgeniy Temirgaleev <e.temirgaleev@tarantool.org
> >
> Cc: tarantool-patches@dev.tarantool.org, Sergey Kaplun <skaplun@tarantool.org
> >
> Date: Thursday, July 2, 2026 5:28 PM +03:00
> RED OS for some reason sets `errno` to 2 ENOENT ("No such file or
> directory") after the call to `mktime()`. So just skip the test for it.
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-os-time-test-redos
> 
> Failed workflow: https://github.com/tarantool/tarantool/actions/runs/28585213455/job/84775371860?pr=12886#step:5:20692
> 
> 
> Side note: The errno is set for __any__ call to the `mktime()`.
> 
> Tested inside the following Docker:
> 
> ===================================================================
> FROM registry.red-soft.ru/ubi8/ubi-minimal:latest
> 
> RUN dnf update -y && \
> dnf install -y cmake vim make git curl gcc g++ gdb man && \
> dnf clean all
> ===================================================================
> 
> | docker build . --tag redos
> | docker run --network=host -ti redos bash
> 
> Then clone LuaJIT and proceed as usual.
> 
> With the patch the test skipped:
> | 1..0 # SKIP RedOS incrorrect behaviour for mktime
> 
> .../lj-1470-os-time-epoch-minus-1s.test.lua | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> index dfe1ee11..ebfe6f22 100644
> --- a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> +++ b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> @@ -1,9 +1,25 @@
> local tap = require('tap')
> 
> +local function detect_redos()
> + local read_file = require('utils').tools.read_file
> + local hasfile, data = pcall(read_file, '/etc/os-release')
> + if not hasfile then
> + -- Not Linux probably, so not the Red OS.
> + return false
> + else
> + return data:match('RED OS')
> + end
> +end
> +
> -- The test file demonstrates os.time() fail to return -1 time
> -- value.
> -- See also: https://github.com/LuaJIT/LuaJIT/issues/1470.
> -local test = tap.test('lj-1470-os-time-epoch-minus-1s')
> +local test = tap.test('lj-1470-os-time-epoch-minus-1s'):skipcond({
> + -- XXX: RED OS for some reason sets `errno` to 2 ENOENT ("No
> + -- such file or directory") after the call to `mktime()`. So
> + -- just skip the test for it.
> + ['RED OS incrorrect behaviour for mktime'] = detect_redos(),
> +})
> 
> test:plan(1)
> 
> --
> 2.54.0
>

[-- Attachment #2: Type: text/html, Size: 3812 bytes --]