Re: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 3160 bytes --]

Sergey,

thanks for the patch! See my comments.

Sergey

On 7/2/26 17:28, Sergey Kaplun wrote:
> RED OS for some reason sets `errno` to 2 ENOENT ("No such file or
> directory") after the call to `mktime()`. So just skip the test for it.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/fix-os-time-test-redos
> Failed workflow:https://github.com/tarantool/tarantool/actions/runs/28585213455/job/84775371860?pr=12886#step:5:20692
>
> Side note: The errno is set for __any__ call to the `mktime()`.
>
> Tested inside the following Docker:
>
> ===================================================================
> FROM registry.red-soft.ru/ubi8/ubi-minimal:latest
>
> RUN dnf update -y && \
>      dnf install -y cmake vim make git curl gcc g++ gdb man && \
>      dnf clean all
> ===================================================================
>
> | docker build . --tag redos
> | docker run --network=host -ti redos bash
>
> Then clone LuaJIT and proceed as usual.
>
> With the patch the test skipped:
> | 1..0 # SKIP RedOS incrorrect behaviour for mktime
>
>   .../lj-1470-os-time-epoch-minus-1s.test.lua    | 18 +++++++++++++++++-
>   1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> index dfe1ee11..ebfe6f22 100644
> --- a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> +++ b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
> @@ -1,9 +1,25 @@
>   local tap = require('tap')
>   
> +local function detect_redos()
> +  local read_file = require('utils').tools.read_file
> +  local hasfile, data = pcall(read_file, '/etc/os-release')
> +  if not hasfile then
> +    -- Not Linux probably, so not the Red OS.
> +    return false
> +  else
> +    returndata:match('RED OS')
> +  end
> +end

Why do you think the problem is in RedOS, not in Glibc?

I propose skipping test for some Glibc version using CMake macro

introduced in the following commit:

commit af0f59da76292f30ff75be1ab01458d47b226995
Author: Sergey Kaplun <skaplun@tarantool.org>
Date:   Wed Dec 4 15:03:56 2024 +0300

     test: fix LuaJIT-tests for old libc version

Otherwise, we will skip this test for always for RedOS.

in RedOS 8 glibc version is 2.36-14:

[root@pony /]# rpm -qa | grep glibc
glibc-common-2.36-14.red80.x86_64
glibc-gconv-extra-2.36-14.red80.x86_64
glibc-langpack-en-2.36-14.red80.x86_64
glibc-langpack-ru-2.36-14.red80.x86_64
glibc-2.36-14.red80.x86_64
glibc-devel-2.36-14.red80.x86_64



Also, why detect_redos() is not in utils.lua?

> +
>   -- The test file demonstrates os.time() fail to return -1 time
>   -- value.
>   -- See also:https://github.com/LuaJIT/LuaJIT/issues/1470.
> -local test = tap.test('lj-1470-os-time-epoch-minus-1s')
> +local test = tap.test('lj-1470-os-time-epoch-minus-1s'):skipcond({
> +  -- XXX: RED OS for some reason sets `errno` to 2 ENOENT ("No
> +  -- such file or directory") after the call to `mktime()`. So
> +  -- just skip the test for it.
> +  ['RED OS incrorrect behaviour for mktime'] = detect_redos(),
> +})
>   
>   test:plan(1)
>   

[-- Attachment #2: Type: text/html, Size: 4528 bytes --]