From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 42BA96ECDE; Thu, 2 Jul 2026 19:03:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 42BA96ECDE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1783008181; bh=TvOeazS0PFo+HXal+D13Gqj8PwsYDUQdN8RnK5sXn8Q=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ewAL7FrB8JqsI8njEOoJnWn39ZzbC+azTz51a7qx9/UsOjti/Lt3ivksEDUBurEiY 4kN1fSKmewlEcdyRBTh3WU65I2i5t7la6ho2hAFIL1XI/Ek0T+r3s2tY4hngIKx5aD 3VpYjQfSnPNZPkcbDiaMDYV/vavQ2f0kPgNk0TyM= Received: from send241.i.mail.ru (send241.i.mail.ru [95.163.59.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 60D0C6ECDE for ; Thu, 2 Jul 2026 19:02:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 60D0C6ECDE Received: by exim-smtp-9d444bb98-xqhd4 with esmtpa (envelope-from ) id 1wfJsQ-00000000Hb1-0fUq; Thu, 02 Jul 2026 19:02:58 +0300 Content-Type: multipart/alternative; boundary="------------1BfTZl73CTZdrcY8vDNQI0hN" Message-ID: Date: Thu, 2 Jul 2026 19:02:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260702142817.2292243-1-skaplun@tarantool.org> In-Reply-To: <20260702142817.2292243-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD981A70198B9CDD16A61026D0C915B49DBAA03A7EF3A474ED8182A05F5380850404C228DA9ACA6FE277759F730E4D5E8853DE06ABAFEAF6705C36944895EDB93B946A1E08967FFF322039F47AC1EBC7B57 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74D0D2DEF2EB846B0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375665EC6F5188975CE8377DCFFAD42206E8094767B28FA472BE6A3891F187128DC33389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE765B758295022C166731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A560B1F3E3865768555002B1117B3ED696C29D3A7C67A8FEB847A99E6294EE86613610D81D389A125CDE35189EBF2DEA28FEA14CD2CD220BB99C5DF10A05D560A9880EC71AF561E0AAD9143641EC25BB39B7082704C90D4841 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65917D20EE274DC3063CDBDD10BA867B627BEA35E35F122975BA2F05E4C490CDD47197C61C493F809DCB8341EE9D5BE9A0AADE76925D72908FA0365FDFB8286927DA72B4A8F2513091D6536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQ2xbpK5Vic+Tb2NtPwtLL0= X-DA7885C5: DD2D149A8F84334EF255D290C0D534F9E4FB39A42CE2F16E42580108660D40367A9F83811A24C8295B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2593A9CC98E1128F155E621498B6D4819E1A575556E3159A4EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------1BfTZl73CTZdrcY8vDNQI0hN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sergey, thanks for the patch! See my comments. Sergey On 7/2/26 17:28, Sergey Kaplun wrote: > RED OS for some reason sets `errno` to 2 ENOENT ("No such file or > directory") after the call to `mktime()`. So just skip the test for it. > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/fix-os-time-test-redos > Failed workflow:https://github.com/tarantool/tarantool/actions/runs/28585213455/job/84775371860?pr=12886#step:5:20692 > > Side note: The errno is set for __any__ call to the `mktime()`. > > Tested inside the following Docker: > > =================================================================== > FROM registry.red-soft.ru/ubi8/ubi-minimal:latest > > RUN dnf update -y && \ > dnf install -y cmake vim make git curl gcc g++ gdb man && \ > dnf clean all > =================================================================== > > | docker build . --tag redos > | docker run --network=host -ti redos bash > > Then clone LuaJIT and proceed as usual. > > With the patch the test skipped: > | 1..0 # SKIP RedOS incrorrect behaviour for mktime > > .../lj-1470-os-time-epoch-minus-1s.test.lua | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua > index dfe1ee11..ebfe6f22 100644 > --- a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua > +++ b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua > @@ -1,9 +1,25 @@ > local tap = require('tap') > > +local function detect_redos() > + local read_file = require('utils').tools.read_file > + local hasfile, data = pcall(read_file, '/etc/os-release') > + if not hasfile then > + -- Not Linux probably, so not the Red OS. > + return false > + else > + returndata:match('RED OS') > + end > +end Why do you think the problem is in RedOS, not in Glibc? I propose skipping test for some Glibc version using CMake macro introduced in the following commit: commit af0f59da76292f30ff75be1ab01458d47b226995 Author: Sergey Kaplun Date:   Wed Dec 4 15:03:56 2024 +0300     test: fix LuaJIT-tests for old libc version Otherwise, we will skip this test for always for RedOS. in RedOS 8 glibc version is 2.36-14: [root@pony /]# rpm -qa | grep glibc glibc-common-2.36-14.red80.x86_64 glibc-gconv-extra-2.36-14.red80.x86_64 glibc-langpack-en-2.36-14.red80.x86_64 glibc-langpack-ru-2.36-14.red80.x86_64 glibc-2.36-14.red80.x86_64 glibc-devel-2.36-14.red80.x86_64 Also, why detect_redos() is not in utils.lua? > + > -- The test file demonstrates os.time() fail to return -1 time > -- value. > -- See also:https://github.com/LuaJIT/LuaJIT/issues/1470. > -local test = tap.test('lj-1470-os-time-epoch-minus-1s') > +local test = tap.test('lj-1470-os-time-epoch-minus-1s'):skipcond({ > + -- XXX: RED OS for some reason sets `errno` to 2 ENOENT ("No > + -- such file or directory") after the call to `mktime()`. So > + -- just skip the test for it. > + ['RED OS incrorrect behaviour for mktime'] = detect_redos(), > +}) > > test:plan(1) > --------------1BfTZl73CTZdrcY8vDNQI0hN Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Sergey,

thanks for the patch! See my comments.

Sergey

On 7/2/26 17:28, Sergey Kaplun wrote:
RED OS for some reason sets `errno` to 2 ENOENT ("No such file or
directory") after the call to `mktime()`. So just skip the test for it.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-os-time-test-redos
Failed workflow: https://github.com/tarantool/tarantool/actions/runs/28585213455/job/84775371860?pr=12886#step:5:20692

Side note: The errno is set for __any__ call to the `mktime()`.

Tested inside the following Docker:

===================================================================
FROM registry.red-soft.ru/ubi8/ubi-minimal:latest

RUN dnf update -y && \
    dnf install -y cmake vim make git curl gcc g++ gdb man && \
    dnf clean all
===================================================================

| docker build . --tag redos
| docker run --network=host -ti redos bash

Then clone LuaJIT and proceed as usual.

With the patch the test skipped:
| 1..0 # SKIP RedOS incrorrect behaviour for mktime

 .../lj-1470-os-time-epoch-minus-1s.test.lua    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
index dfe1ee11..ebfe6f22 100644
--- a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
+++ b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
@@ -1,9 +1,25 @@
 local tap = require('tap')
 
+local function detect_redos()
+  local read_file = require('utils').tools.read_file
+  local hasfile, data = pcall(read_file, '/etc/os-release')
+  if not hasfile then
+    -- Not Linux probably, so not the Red OS.
+    return false
+  else
+    return data:match('RED OS')
+  end
+end

Why do you think the problem is in RedOS, not in Glibc?

I propose skipping test for some Glibc version using CMake macro 

introduced in the following commit:

commit af0f59da76292f30ff75be1ab01458d47b226995
Author: Sergey Kaplun <skaplun@tarantool.org>
Date:   Wed Dec 4 15:03:56 2024 +0300

    test: fix LuaJIT-tests for old libc version

Otherwise, we will skip this test for always for RedOS.

in RedOS 8 glibc version is 2.36-14:

[root@pony /]# rpm -qa | grep glibc
glibc-common-2.36-14.red80.x86_64
glibc-gconv-extra-2.36-14.red80.x86_64
glibc-langpack-en-2.36-14.red80.x86_64
glibc-langpack-ru-2.36-14.red80.x86_64
glibc-2.36-14.red80.x86_64
glibc-devel-2.36-14.red80.x86_64



Also, why detect_redos() is not in utils.lua?

+
 -- The test file demonstrates os.time() fail to return -1 time
 -- value.
 -- See also: https://github.com/LuaJIT/LuaJIT/issues/1470.
-local test = tap.test('lj-1470-os-time-epoch-minus-1s')
+local test = tap.test('lj-1470-os-time-epoch-minus-1s'):skipcond({
+  -- XXX: RED OS for some reason sets `errno` to 2 ENOENT ("No
+  -- such file or directory") after the call to `mktime()`. So
+  -- just skip the test for it.
+  ['RED OS incrorrect behaviour for mktime'] = detect_redos(),
+})
 
 test:plan(1)
--------------1BfTZl73CTZdrcY8vDNQI0hN--