From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>,
Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS
Date: Thu, 2 Jul 2026 17:28:17 +0300 [thread overview]
Message-ID: <20260702142817.2292243-1-skaplun@tarantool.org> (raw)
RED OS for some reason sets `errno` to 2 ENOENT ("No such file or
directory") after the call to `mktime()`. So just skip the test for it.
---
Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-os-time-test-redos
Failed workflow: https://github.com/tarantool/tarantool/actions/runs/28585213455/job/84775371860?pr=12886#step:5:20692
Side note: The errno is set for __any__ call to the `mktime()`.
Tested inside the following Docker:
===================================================================
FROM registry.red-soft.ru/ubi8/ubi-minimal:latest
RUN dnf update -y && \
dnf install -y cmake vim make git curl gcc g++ gdb man && \
dnf clean all
===================================================================
| docker build . --tag redos
| docker run --network=host -ti redos bash
Then clone LuaJIT and proceed as usual.
With the patch the test skipped:
| 1..0 # SKIP RedOS incrorrect behaviour for mktime
.../lj-1470-os-time-epoch-minus-1s.test.lua | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
index dfe1ee11..ebfe6f22 100644
--- a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
+++ b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
@@ -1,9 +1,25 @@
local tap = require('tap')
+local function detect_redos()
+ local read_file = require('utils').tools.read_file
+ local hasfile, data = pcall(read_file, '/etc/os-release')
+ if not hasfile then
+ -- Not Linux probably, so not the Red OS.
+ return false
+ else
+ return data:match('RED OS')
+ end
+end
+
-- The test file demonstrates os.time() fail to return -1 time
-- value.
-- See also: https://github.com/LuaJIT/LuaJIT/issues/1470.
-local test = tap.test('lj-1470-os-time-epoch-minus-1s')
+local test = tap.test('lj-1470-os-time-epoch-minus-1s'):skipcond({
+ -- XXX: RED OS for some reason sets `errno` to 2 ENOENT ("No
+ -- such file or directory") after the call to `mktime()`. So
+ -- just skip the test for it.
+ ['RED OS incrorrect behaviour for mktime'] = detect_redos(),
+})
test:plan(1)
--
2.54.0
next reply other threads:[~2026-07-02 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 14:28 Sergey Kaplun via Tarantool-patches [this message]
2026-07-02 14:45 ` Evgeniy Temirgaleev via Tarantool-patches
2026-07-02 16:02 ` Sergey Bronnikov via Tarantool-patches
2026-07-02 16:30 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702142817.2292243-1-skaplun@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox