Re: [Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Evgeniy!

thanks, LGTM.

Sergey


On 9/29/26 13:33, Evgeniy Temirgaleev wrote:
> Hi, Sergey! The comment's place change is reverted.
>
> The branch is force pushed.
>
> 28.09.2026 16:10, Sergey Bronnikov пишет:
>> Hi, Evgeniy,
>>
>> thanks for fixes! LGTM with a minor comment.
>>
>> On 9/24/26 11:49, Evgeniy Temirgaleev wrote:
>>>
>>>>
>>>> 3. I don't like that we have three copies of ASAN_OPTIONS in the 
>>>> same workflow. It is better to fix this.
>>>
>>> Fixed.
>>
>> Thanks!
>>
>> Why this hunk was moved? Please revert:
>>
>> +
>> +      # Enable as much checks as possible. See more info here:
>> +      # 
>> https://github.com/google/sanitizers/wiki/AddressSanitizerFlags,
>> +      # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags.
>> +      - name: setup common sanitizer options
>>           env:
>> -          # Enable as much checks as possible. See more info here:
>> -          # https://github.com/google/sanitizers/wiki/ 
>> AddressSanitizerFlags,
>> -          # https://github.com/google/sanitizers/wiki/ 
>> SanitizerCommonFlags.
>>             ASAN_OPTIONS: "                    \
>>               detect_invalid_pointer_pairs=1:  \
>>               detect_leaks=1:
>