Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS
Date: Mon, 28 Sep 2026 16:10:28 +0300	[thread overview]
Message-ID: <4ba8ba55-c3f1-40d2-acc0-137bbcb9dadc@tarantool.org> (raw)
In-Reply-To: <67760a66-15f3-41c2-bc20-16a2f9649a5f@tarantool.org>

Hi, Evgeniy,

thanks for fixes! LGTM with a minor comment.

On 9/24/26 11:49, Evgeniy Temirgaleev wrote:
>
>>
>> 3. I don't like that we have three copies of ASAN_OPTIONS in the same 
>> workflow. It is better to fix this.
>
> Fixed.

Thanks!

Why this hunk was moved? Please revert:

+
+      # Enable as much checks as possible. See more info here:
+      # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags,
+      # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags.
+      - name: setup common sanitizer options
          env:
-          # Enable as much checks as possible. See more info here:
-          # 
https://github.com/google/sanitizers/wiki/AddressSanitizerFlags,
-          # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags.
            ASAN_OPTIONS: "                    \
              detect_invalid_pointer_pairs=1:  \
              detect_leaks=1:



  reply	other threads:[~2026-09-28 13:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 12:47 [Tarantool-patches] [PATCH luajit v3 0/3] build: fixed making tests with ASAN on OSX Evgeniy Temirgaleev via Tarantool-patches
2026-08-06 12:47 ` [Tarantool-patches] [PATCH luajit v3 1/3] test: " Evgeniy Temirgaleev via Tarantool-patches
2026-08-18 10:24   ` Sergey Kaplun via Tarantool-patches
2026-08-18 19:23     ` Evgeniy Temirgaleev via Tarantool-patches
2026-08-27 11:53   ` Sergey Bronnikov via Tarantool-patches
2026-08-28 11:14     ` Evgeniy Temirgaleev via Tarantool-patches
2026-08-31  8:47       ` Sergey Bronnikov via Tarantool-patches
2026-08-06 12:47 ` [Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS Evgeniy Temirgaleev via Tarantool-patches
2026-08-18 10:47   ` Sergey Kaplun via Tarantool-patches
2026-08-18 20:35     ` Evgeniy Temirgaleev via Tarantool-patches
2026-08-19  7:30       ` Sergey Kaplun via Tarantool-patches
2026-08-20  7:53         ` Evgeniy Temirgaleev via Tarantool-patches
2026-08-27 12:07   ` Sergey Bronnikov via Tarantool-patches
2026-08-28 15:12     ` Evgeniy Temirgaleev via Tarantool-patches
2026-09-23 14:14       ` Sergey Bronnikov via Tarantool-patches
2026-09-24  8:49         ` Evgeniy Temirgaleev via Tarantool-patches
2026-09-28 13:10           ` Sergey Bronnikov via Tarantool-patches [this message]
2026-08-06 12:47 ` [Tarantool-patches] [PATCH luajit v3 3/3] ci: added a common way to disable perf workflow Evgeniy Temirgaleev via Tarantool-patches
2026-08-18 10:25   ` Sergey Kaplun via Tarantool-patches
2026-08-27 12:16   ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ba8ba55-c3f1-40d2-acc0-137bbcb9dadc@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox