Re: [Tarantool-patches] [PATCH luajit v3 1/3] test: fixed making tests with ASAN on OSX

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 4139 bytes --]

Thanks! LGTM

On 8/28/26 14:14, Evgeniy Temirgaleev wrote:
> Hi, Sergey! Thanks for review!
> Fixed your suggestion.
> The branch is force pushed.
>
>     From: Sergey Bronnikov <sergeyb@tarantool.org>
>     To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>, Sergey
>     Kaplun <skaplun@tarantool.org>
>     Cc:tarantool-patches@dev.tarantool.org
>     Date: Thursday, August 27, 2026 2:53 PM +03:00
>     Hi, Evgeniy,
>
>     thanks for the patch! LGTM with a minor comment below.
>
>
>     Sergey
>
>     On 8/6/26 15:47, Evgeniy Temirgaleev wrote:
>     > From: Temir Galeev <temir.galeev@bk.ru>
>     >
>     > LuaJIT tests use fixup for Linux to run binaries made with
>     > the ASAN option. Our LibRealPath module is used for it.
>     > This module doesn't support OSX and breaks the make process.
>     >
>     > So, we disable the fixup for OSX to allow LuaJIT making
>     > and running the tests with ASAN enabled.
>     > ---
>     > test/LuaJIT-tests/CMakeLists.txt | 3 ++-
>     > test/tarantool-tests/CMakeLists.txt | 3 ++-
>     > 2 files changed, 4 insertions(+), 2 deletions(-)
>     >
>     > diff --git a/test/LuaJIT-tests/CMakeLists.txt
>     b/test/LuaJIT-tests/CMakeLists.txt
>     > index c1dbde35..42967cbc 100644
>     > --- a/test/LuaJIT-tests/CMakeLists.txt
>     > +++ b/test/LuaJIT-tests/CMakeLists.txt
>     > @@ -17,7 +17,8 @@ else()
>     > list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
>     > endif()
>     >
>     > -if(LUAJIT_USE_ASAN)
>     > +if(LUAJIT_USE_ASAN
>     > + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
>
>     could you please put logical operators on the previous line? Like
>     this:
>
>     if(LUAJIT_USE_ASAN AND NOT
>
>       CMAKE_SYSTEM_NAME STREQUAL "Darwin")
>
>     the same below
>
>     > # When running LuaJIT-tests under ASAN, the internal ASAN check
>     > # failed:
>     > # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356
>     > diff --git a/test/tarantool-tests/CMakeLists.txt
>     b/test/tarantool-tests/CMakeLists.txt
>     > index 682a883a..e9930e22 100644
>     > --- a/test/tarantool-tests/CMakeLists.txt
>     > +++ b/test/tarantool-tests/CMakeLists.txt
>     > @@ -183,7 +183,8 @@ endforeach()
>     > # required that the ASan library go first in the `LD_PRELOAD`
>     > # list. Set it manually. The test will append it to the executed
>     > # process.
>     > -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU")
>     > +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"
>     > + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
>     > LibRealPath(LIB_ASAN libasan.so)
>     > AppendTestEnvVar(
>     > "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"
>
> diff --git a/test/LuaJIT-tests/CMakeLists.txt 
> b/test/LuaJIT-tests/CMakeLists.txt
> index 42967cbc..f08762b3 100644
> --- a/test/LuaJIT-tests/CMakeLists.txt
> +++ b/test/LuaJIT-tests/CMakeLists.txt
> @@ -17,8 +17,8 @@ else()
>    list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
>  endif()
> -if(LUAJIT_USE_ASAN
> -   AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> +if(LUAJIT_USE_ASAN AND NOT
> +   CMAKE_SYSTEM_NAME STREQUAL "Darwin")
>    # When running LuaJIT-tests under ASAN, the internal ASAN check
>    # failed:
>    # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356
> diff --git a/test/tarantool-tests/CMakeLists.txt 
> b/test/tarantool-tests/CMakeLists.txt
> index e9930e22..fcd6d692 100644
> --- a/test/tarantool-tests/CMakeLists.txt
> +++ b/test/tarantool-tests/CMakeLists.txt
> @@ -183,8 +183,8 @@ endforeach()
>  # required that the ASan library go first in the `LD_PRELOAD`
>  # list. Set it manually. The test will append it to the executed
>  # process.
> -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"
> -   AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU" AND NOT
> +   CMAKE_SYSTEM_NAME STREQUAL "Darwin")
>    LibRealPath(LIB_ASAN libasan.so)
>    AppendTestEnvVar(
>  "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"
> --
> Best regards,
> Evgeniy Temirgaleev

[-- Attachment #2: Type: text/html, Size: 8746 bytes --]