Re: [Tarantool-patches] [PATCH luajit v3 1/3] test: fixed making tests with ASAN on OSX

[Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]

Hi, Sergey! Thanks for review!

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
> Cc: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org
> 
> Date: Tuesday, August 18, 2026 1:25 PM +03:00
> Hi, Evgeniy!
> Thanks for the patch and fixes.
> LGTM, with the minor nit below.
> 
> On 06.08.26, Evgeniy Temirgaleev wrote:
> > From: Temir Galeev <temir.galeev@bk.ru>
> 
> <snipped>
> 
> > ---
> > test/LuaJIT-tests/CMakeLists.txt | 3 ++-
> > test/tarantool-tests/CMakeLists.txt | 3 ++-
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/test/LuaJIT-tests/CMakeLists.txt
> b/test/LuaJIT-tests/CMakeLists.txt
> > index c1dbde35..42967cbc 100644
> > --- a/test/LuaJIT-tests/CMakeLists.txt
> > +++ b/test/LuaJIT-tests/CMakeLists.txt
> > @@ -17,7 +17,8 @@ else()
> > list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
> > endif()
> >
> > -if(LUAJIT_USE_ASAN)
> > +if(LUAJIT_USE_ASAN
> > + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> 
> Minor: Looks like these lines may be joint.
> 

It was so. But when I added this guard to the second place, I decided to make the change same in both places.

> 
> 
> > # When running LuaJIT-tests under ASAN, the internal ASAN check
> > # failed:
> > # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356
> > diff --git a/test/tarantool-tests/CMakeLists.txt
> b/test/tarantool-tests/CMakeLists.txt
> > index 682a883a..e9930e22 100644
> > --- a/test/tarantool-tests/CMakeLists.txt
> > +++ b/test/tarantool-tests/CMakeLists.txt
> > @@ -183,7 +183,8 @@ endforeach()
> > # required that the ASan library go first in the `LD_PRELOAD`
> > # list. Set it manually. The test will append it to the executed
> > # process.
> > -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU")
> > +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"
> > + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> > LibRealPath(LIB_ASAN libasan.so)
> > AppendTestEnvVar(
> > "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"
> > --
> > 2.49.0
> >
> 
> --
> Best regards,
> Sergey Kaplun
> 

Best regards,
Evgeniy Temirgaleev

[-- Attachment #2: Type: text/html, Size: 3391 bytes --]