From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B89FC6ECCC; Mon, 31 Aug 2026 11:47:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B89FC6ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1788166048; bh=zMaQA2Lter7/ZzmuM2Iap8umL++8jizMSC0yduf7b/c=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DA1f25lGheA+G0WQUut5NbR89uDm5ZSRSMG9kI5bIId+/iqgoUjY4zWc8V8nQ1Fq/ vh1GGmpXn69DQ0NMu6YuZKmezH0n1xDSV5/Du4PCMdLGLyh6oXKWtih2FHG5e/jz4q meFlcAI5sHxiYPGjVQJKAqw6ql3+uz1G2WGkMf5M= Received: from send59.i.mail.ru (send59.i.mail.ru [89.221.237.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DCAFE6ECCC for ; Mon, 31 Aug 2026 11:47:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DCAFE6ECCC Received: by exim-smtp-67896c5f6-x6w25 with esmtpa (envelope-from ) id 1x0xfp-000000001jB-2Nyj; Mon, 31 Aug 2026 11:47:26 +0300 Content-Type: multipart/alternative; boundary="------------AzeIg4oqLU2H85DjQiGlcspG" Message-ID: <91685ea9-ba0a-48a3-a586-05e93dfd25ec@tarantool.org> Date: Mon, 31 Aug 2026 11:47:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Evgeniy Temirgaleev References: <45128c7b-6f0a-4c87-9a62-03c1d6a94376@tarantool.org> <1787915696.293673980@f554.i.mail.ru> Content-Language: en-US In-Reply-To: <1787915696.293673980@f554.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D7C1672FFCCD5B16EE9C429B9E69D3B195143BB4266AFB191313CFAB8367EF908E2BE116634AD74D4C4DE10C873AB7579487ABAC94A94B54932B68044D0CC7D753020507E3FA7F4521323E01452AE1F2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE711269A7C2F827F16EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D850E07A5DCD3FA8D531CD0D9267D3CF67101EBD0FEB562260FC8F90F84904EF389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0B27420F9988F54058941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D07623A0E6354027CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE73A6989AD488FD87D731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A59D78363590BDD5655002B1117B3ED6966FD22D36CF371544108A05421C070DB83610D81D389A125CDE35189EBF2DEA28FEA14CD2CD220BB99C5DF10A05D560A9880EC71AF561E0AAD9143641EC25BB390CBC66767E1C2D61 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65935CEF1734944531D3B6E55DA9F93A595C5FC5C8D5EE2D80F50EA07F3C933B1EC33F786611EA99EC4B8341EE9D5BE9A0AC6542DEF37E715C6A60DDE898D2311B80890959C03D0475E6536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVYRi1g7C0l6kXg3lNHOMcBE= X-Mailru-Sender: 689FA8AB762F73937C9FA53A4753B313DF72E7CE3BEB842CB0E81E03CBE0DD60E9F74F4542B2CBB2EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 1/3] test: fixed making tests with ASAN on OSX X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------AzeIg4oqLU2H85DjQiGlcspG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thanks! LGTM On 8/28/26 14:14, Evgeniy Temirgaleev wrote: > Hi, Sergey! Thanks for review! > Fixed your suggestion. > The branch is force pushed. > > From: Sergey Bronnikov > To: Evgeniy Temirgaleev , Sergey > Kaplun > Cc:tarantool-patches@dev.tarantool.org > Date: Thursday, August 27, 2026 2:53 PM +03:00 > Hi, Evgeniy, > > thanks for the patch! LGTM with a minor comment below. > > > Sergey > > On 8/6/26 15:47, Evgeniy Temirgaleev wrote: > > From: Temir Galeev > > > > LuaJIT tests use fixup for Linux to run binaries made with > > the ASAN option. Our LibRealPath module is used for it. > > This module doesn't support OSX and breaks the make process. > > > > So, we disable the fixup for OSX to allow LuaJIT making > > and running the tests with ASAN enabled. > > --- > > test/LuaJIT-tests/CMakeLists.txt | 3 ++- > > test/tarantool-tests/CMakeLists.txt | 3 ++- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/test/LuaJIT-tests/CMakeLists.txt > b/test/LuaJIT-tests/CMakeLists.txt > > index c1dbde35..42967cbc 100644 > > --- a/test/LuaJIT-tests/CMakeLists.txt > > +++ b/test/LuaJIT-tests/CMakeLists.txt > > @@ -17,7 +17,8 @@ else() > > list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > > endif() > > > > -if(LUAJIT_USE_ASAN) > > +if(LUAJIT_USE_ASAN > > + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin") > > could you please put logical operators on the previous line? Like > this: > > if(LUAJIT_USE_ASAN AND NOT > >   CMAKE_SYSTEM_NAME STREQUAL "Darwin") > > the same below > > > # When running LuaJIT-tests under ASAN, the internal ASAN check > > # failed: > > # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356 > > diff --git a/test/tarantool-tests/CMakeLists.txt > b/test/tarantool-tests/CMakeLists.txt > > index 682a883a..e9930e22 100644 > > --- a/test/tarantool-tests/CMakeLists.txt > > +++ b/test/tarantool-tests/CMakeLists.txt > > @@ -183,7 +183,8 @@ endforeach() > > # required that the ASan library go first in the `LD_PRELOAD` > > # list. Set it manually. The test will append it to the executed > > # process. > > -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU") > > +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU" > > + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin") > > LibRealPath(LIB_ASAN libasan.so) > > AppendTestEnvVar( > > "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua" > > diff --git a/test/LuaJIT-tests/CMakeLists.txt > b/test/LuaJIT-tests/CMakeLists.txt > index 42967cbc..f08762b3 100644 > --- a/test/LuaJIT-tests/CMakeLists.txt > +++ b/test/LuaJIT-tests/CMakeLists.txt > @@ -17,8 +17,8 @@ else() >    list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") >  endif() > -if(LUAJIT_USE_ASAN > -   AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin") > +if(LUAJIT_USE_ASAN AND NOT > +   CMAKE_SYSTEM_NAME STREQUAL "Darwin") >    # When running LuaJIT-tests under ASAN, the internal ASAN check >    # failed: >    # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356 > diff --git a/test/tarantool-tests/CMakeLists.txt > b/test/tarantool-tests/CMakeLists.txt > index e9930e22..fcd6d692 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -183,8 +183,8 @@ endforeach() >  # required that the ASan library go first in the `LD_PRELOAD` >  # list. Set it manually. The test will append it to the executed >  # process. > -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU" > -   AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin") > +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU" AND NOT > +   CMAKE_SYSTEM_NAME STREQUAL "Darwin") >    LibRealPath(LIB_ASAN libasan.so) >    AppendTestEnvVar( >  "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua" > -- > Best regards, > Evgeniy Temirgaleev --------------AzeIg4oqLU2H85DjQiGlcspG Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Thanks! LGTM

On 8/28/26 14:14, Evgeniy Temirgaleev wrote:
Hi, Sergey! Thanks for review!
Fixed your suggestion.
The branch is force pushed.
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>, Sergey Kaplun <skaplun@tarantool.org>
Cc:tarantool-patches@dev.tarantool.org
Date: Thursday, August 27, 2026 2:53 PM +03:00
 
Hi, Evgeniy,

thanks for the patch! LGTM with a minor comment below.


Sergey

On 8/6/26 15:47, Evgeniy Temirgaleev wrote:
> From: Temir Galeev <temir.galeev@bk.ru>
>
> LuaJIT tests use fixup for Linux to run binaries made with
> the ASAN option. Our LibRealPath module is used for it.
> This module doesn't support OSX and breaks the make process.
>
> So, we disable the fixup for OSX to allow LuaJIT making
> and running the tests with ASAN enabled.
> ---
> test/LuaJIT-tests/CMakeLists.txt | 3 ++-
> test/tarantool-tests/CMakeLists.txt | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt
> index c1dbde35..42967cbc 100644
> --- a/test/LuaJIT-tests/CMakeLists.txt
> +++ b/test/LuaJIT-tests/CMakeLists.txt
> @@ -17,7 +17,8 @@ else()
> list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
> endif()
>
> -if(LUAJIT_USE_ASAN)
> +if(LUAJIT_USE_ASAN
> + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")

could you please put logical operators on the previous line? Like this:

if(LUAJIT_USE_ASAN AND NOT

  CMAKE_SYSTEM_NAME STREQUAL "Darwin")

the same below

> # When running LuaJIT-tests under ASAN, the internal ASAN check
> # failed:
> # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356
> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
> index 682a883a..e9930e22 100644
> --- a/test/tarantool-tests/CMakeLists.txt
> +++ b/test/tarantool-tests/CMakeLists.txt
> @@ -183,7 +183,8 @@ endforeach()
> # required that the ASan library go first in the `LD_PRELOAD`
> # list. Set it manually. The test will append it to the executed
> # process.
> -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU")
> +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"
> + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> LibRealPath(LIB_ASAN libasan.so)
> AppendTestEnvVar(
> "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"
diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt
index 42967cbc..f08762b3 100644
--- a/test/LuaJIT-tests/CMakeLists.txt
+++ b/test/LuaJIT-tests/CMakeLists.txt
@@ -17,8 +17,8 @@ else()
   list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
 endif()
 
-if(LUAJIT_USE_ASAN
-   AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
+if(LUAJIT_USE_ASAN AND NOT
+   CMAKE_SYSTEM_NAME STREQUAL "Darwin")
   # When running LuaJIT-tests under ASAN, the internal ASAN check
   # failed:
   # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356
diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
index e9930e22..fcd6d692 100644
--- a/test/tarantool-tests/CMakeLists.txt
+++ b/test/tarantool-tests/CMakeLists.txt
@@ -183,8 +183,8 @@ endforeach()
 # required that the ASan library go first in the `LD_PRELOAD`
 # list. Set it manually. The test will append it to the executed
 # process.
-if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"
-   AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
+if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU" AND NOT
+   CMAKE_SYSTEM_NAME STREQUAL "Darwin")
   LibRealPath(LIB_ASAN libasan.so)
   AppendTestEnvVar(
     "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"
--
Best regards,
Evgeniy Temirgaleev
--------------AzeIg4oqLU2H85DjQiGlcspG--