Tarantool development patches archive
 help / color / mirror / Atom feed
* Re: [Tarantool-patches] [PATCH luajit 1/2] c: disable strcmp optimization in Valgrind build
       [not found] ` <20240626122735.165672-2-mandesero@gmail.com>
@ 2024-07-03 10:10   ` Sergey Kaplun via Tarantool-patches
  0 siblings, 0 replies; only message in thread
From: Sergey Kaplun via Tarantool-patches @ 2024-07-03 10:10 UTC (permalink / raw)
  To: mandesero; +Cc: tarantool-patches

Hi, Maxim!
Thanks for the patch!
Please consider my comment below.

On 26.06.24, mandesero@gmail.com wrote:
> From: mandesero <mandesero@gmail.com>
> 
> ---
>  src/lj_str.c | 43 +++++++++++++++++++++++++++++++++++++++++--

AFAICS, the <src/lj.supp> contains Valgrind suppressions for
`lj_str_cmp()` and `str_fastcmp()`. The upstream politics until
ff34b48ddd6f2b3bdd26d6088662a214ba6b0288 ("Redesign and harden string
interning.") [1] is to use this file for all suppressions (see the
corresponding comments in the commit). So I suggest dropping this patch
and introducing testing with suppressions in the CI in another patch (as
it is done). Are there any objections to this?

[1]: https://github.com/LuaJIT/LuaJIT/commit/ff34b48ddd6f2b3bdd26d6088662a214ba6b0288

>  1 file changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lj_str.c b/src/lj_str.c
> index 321e8c4f..00cced03 100644
> --- a/src/lj_str.c
> +++ b/src/lj_str.c

<snipped>

> -- 
> 2.34.1
> 

-- 
Best regards,
Sergey Kaplun

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-07-03 10:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240626122735.165672-1-mandesero@gmail.com>
     [not found] ` <20240626122735.165672-2-mandesero@gmail.com>
2024-07-03 10:10   ` [Tarantool-patches] [PATCH luajit 1/2] c: disable strcmp optimization in Valgrind build Sergey Kaplun via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox