From: mandesero--- via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Cc: mandesero <mandesero@gmail.com> Subject: [Tarantool-patches] [PATCH luajit 0/2] Disable strcmp optimizations in Valgrind build Date: Wed, 26 Jun 2024 12:27:33 +0000 [thread overview] Message-ID: <20240626122735.165672-1-mandesero@gmail.com> (raw) From: mandesero <mandesero@gmail.com> In this Patchset, the optimization of strcmp is disabled during the LuaJIT build under Valgrind. The string comparison is done byte-by-byte. Additionally, the memcmp functions, where strings are compared, have been replaced to disable any potential internal optimizations. Branch: https://github.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug Issue: https://github.com/tarantool/tarantool/issues/3705 Some tests are failing under Valgrind due to the timer profiler (SIGPROF) or upon reaching the maximum test duration, so they have been disabled. mandesero (2): c: disable strcmp optimization in Valgrind build cmake: running tests under Valgrind, disable tests that failed under Valgrind .github/actions/setup-sanitizers/action.yml | 2 +- .github/workflows/sanitizers-testing.yml | 53 +++++++++++++++++++++ src/lj_no_str_opt.supp | 16 +++++++ src/lj_str.c | 43 ++++++++++++++++- test/CMakeLists.txt | 6 ++- test/tarantool-tests/CMakeLists.txt | 17 +++++++ 6 files changed, 133 insertions(+), 4 deletions(-) create mode 100644 src/lj_no_str_opt.supp -- 2.34.1
next reply other threads:[~2024-07-29 17:51 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-26 12:27 mandesero--- via Tarantool-patches [this message] 2024-06-26 12:27 ` [Tarantool-patches] [PATCH luajit 1/2] c: disable strcmp optimization " mandesero--- via Tarantool-patches 2024-07-03 10:10 ` Sergey Kaplun via Tarantool-patches 2024-06-26 12:27 ` [Tarantool-patches] [PATCH luajit 2/2] cmake: running tests under Valgrind, disable tests that failed under Valgrind mandesero--- via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240626122735.165672-1-mandesero@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=mandesero@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Disable strcmp optimizations in Valgrind build' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox