From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6C13655962A; Mon, 29 Jul 2024 20:51:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6C13655962A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1722275476; bh=gBwbmtSjJBKVVYKg6gY4Xo6j/Ske/aD9Mg05bB4PF9k=; h=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=mQ0s1fdmO1nJgevn8DDRJs5Scif/dP/ZyizbzTSUQAOipgl6YG2+zMMpuTTI4/rvz n/qVzay8Lowk73eGAIrrsD/Y3X3AlzS8kNkL9ScUTX69oc+Cxem+pH8f96k6YaSx5d hHDEefkyK+lgjnpLBKeCCxXgHuA1ZcLviw3VBppY= Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 08F01BB0088 for ; Wed, 26 Jun 2024 15:27:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 08F01BB0088 Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52cdea1387eso4354714e87.0 for ; Wed, 26 Jun 2024 05:27:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719404857; x=1720009657; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pe59DC2QgcAwCXBFUrnhM3R997tZjqJReyXTjVT2h7Y=; b=ABAzsa9bB5bwXoFwIghEQ2fujJdk5pN57WQuQxGNXLQm555m0wfRGdXxG6Fzv2d6sU wXIevgZHAKfUtFw/LR2K04kHa8lERVMu8A53WKd46qcD/dTYj01CjD8BxjvLOUP6QTOI u9176vJbjgUrqOqGK9y2E8wf5kk30G+pZCNFh+5u5l2dUSGX6XY/l91qoKU4EUGNYFat DborWK6qJIwinLeFcp+5Rxhx4GTuEBmLISWl1ukxZ+Y3AtgBH/ZkYJGzCrdsZw6VhKDs V2DoZT5kcWjHcNV3dq0O4lNrkkrpcezGI+OoelFktDScBJixBSCvmrs9dn2EXTuO/sXs +Egw== X-Gm-Message-State: AOJu0Yxm3tvo/ZOvKK6geyxoi/w9ZR4nrrTiQLkxsfAgwme732sZoBk2 gLjU6cbqfbhNpdTt4Ld2VBYQOTNzkwVZW4yzMCaWcKyshBRR6tSxsvMcbP4lINw= X-Google-Smtp-Source: AGHT+IHJRH7oYDMhcfMe/aml/3rRzJqgVb6MkZ+5ByGxu2eQRbPEI9Z68BAhdFuDUhqGdUURDPZrBw== X-Received: by 2002:a05:6512:3caa:b0:52c:cccf:85e1 with SMTP id 2adb3069b0e04-52ce1865a49mr8653261e87.65.1719404856880; Wed, 26 Jun 2024 05:27:36 -0700 (PDT) Received: from mandesero.mail.msk ([5.181.62.96]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd84b23d9sm1508886e87.202.2024.06.26.05.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 05:27:36 -0700 (PDT) To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Cc: mandesero Date: Wed, 26 Jun 2024 12:27:33 +0000 Message-Id: <20240626122735.165672-1-mandesero@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 29 Jul 2024 20:51:14 +0300 Subject: [Tarantool-patches] [PATCH luajit 0/2] Disable strcmp optimizations in Valgrind build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: mandesero--- via Tarantool-patches Reply-To: mandesero@gmail.com Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: mandesero In this Patchset, the optimization of strcmp is disabled during the LuaJIT build under Valgrind. The string comparison is done byte-by-byte. Additionally, the memcmp functions, where strings are compared, have been replaced to disable any potential internal optimizations. Branch: https://github.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug Issue: https://github.com/tarantool/tarantool/issues/3705 Some tests are failing under Valgrind due to the timer profiler (SIGPROF) or upon reaching the maximum test duration, so they have been disabled. mandesero (2): c: disable strcmp optimization in Valgrind build cmake: running tests under Valgrind, disable tests that failed under Valgrind .github/actions/setup-sanitizers/action.yml | 2 +- .github/workflows/sanitizers-testing.yml | 53 +++++++++++++++++++++ src/lj_no_str_opt.supp | 16 +++++++ src/lj_str.c | 43 ++++++++++++++++- test/CMakeLists.txt | 6 ++- test/tarantool-tests/CMakeLists.txt | 17 +++++++ 6 files changed, 133 insertions(+), 4 deletions(-) create mode 100644 src/lj_no_str_opt.supp -- 2.34.1