Re: [Tarantool-patches] [PATCH luajit 2/2] test: enable CLI-related lua-Harness tests back

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

Thanks for the patch!

On 25.02.24, Maxim Kokryashkin wrote:
> Hi, Igor!
> Thanks for the patch!
> LGTM after fixing comments below.
> On Sun, Feb 25, 2024 at 10:41:07AM +0000, Igor Munkin wrote:
> > Tarantool supports -b and -j options to use LuaJIT modules since the
> > commit bf8b76a4dfc9dd62d4131e90e2ae5d83843b6630 ("lua: proxy -j and -b
> > flags"), so 241-standalone.t and 411-luajit.t tests in lua-Harness
> Typo: s/in lua-Harness/in the lua-Harness/

Fixed, thanks!

> > suite, disabled in the commit 39a4db500db2619359c2c9474be016360252060d
> > ("test: support Tarantool in lua-Harness"), can be enabled back.
> >
> > However, -O options is still not implemented in Tarantool, so the
> Typo: s/is still/are still/

There is another typo: s/options/option/. Fixed, thanks!

> > related part in 411-luajit.t test chunk is still disabled.
> Typo: s/in/in the/

Fixed, thanks!

> >
> > Follows up #5541
> Typo: s/#5541/tarantool/tarantool#5541/

Oops, fixed, thanks!

Side note: you can use another separator to avoid escaping the /. E.g.
braces: s{#5541}{tarantool/tarantool#5541}. However, I'm not a robot, so
the comment is still clear to me ;)

> >
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> >  test/lua-Harness-tests/241-standalone.t | 2 +-
> >  test/lua-Harness-tests/411-luajit.t     | 6 ++++--
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> >

<snipped>

> > --
> > 2.39.2
> >

-- 
Best regards,
IM