From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 527D39B51DC; Sun, 25 Feb 2024 22:44:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 527D39B51DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708890298; bh=gghcncnThXqy0eaWQPxNCcKxdDhbN2aiaq3ks1RMqW8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g2eBXXW5EPSV/p2FkK7YTFLYu2dN2rsx3pqmL58Szc2y8qa/mJC02EVtSCbtYkldi vAEQY13gxDSxJFpCAEE0/HKQdGfJQq2cUqV+yR0OwQdvK6x0VIh94z60OKv942h4F1 DG3cTdOmU2AxzSO6Mdi5tTl76Ca+N4dLtw9p7U+8= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [95.163.41.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 980849B51DC for ; Sun, 25 Feb 2024 22:44:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 980849B51DC Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1reKQi-0000000DVRl-46Ez; Sun, 25 Feb 2024 22:44:57 +0300 Date: Sun, 25 Feb 2024 19:31:59 +0000 To: Maxim Kokryashkin Message-ID: References: <3e891e97ae52ea897bdd4d7d7c8cc18a5335a687.1708856482.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90B4B6FE9E606E49610CC26003E1EEE77FF7BB197BFD5889000894C459B0CD1B9F5370DFBB341869C55F0C20541441631388CBB413361DBC62C9A5AFEB941DA860E54C3044D106D88 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74D0D2DEF2EB846B0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8ED8CFACC1DCF673A3F1440517191C3BFF5ECD2E646B94EE7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3E4C77FD34835E5A2BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C8F21CEC4765490D35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A55809B6CF6B308B955002B1117B3ED696E59AA56F5CF1AFDBF5FEB6EB1EB183FD823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349DAEDEF7DE8FDCFA0DECF7380B6375D7490221AF6F907D6B31D1B4432229487ACC966634B7C89C661D7E09C32AA3244C257D954344895A4B459F46583F07963CAE8D585247504DE7EA455F16B58544A2557BDE0DD54B3590E9CAF2BECF134D6894F255A82739648EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhcsd5OwWmogtMHHdTtBiUg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5310030B17043F43F48125AE33D5AC58CD4DBBEF026BA4D38FA933167630E846540F5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] test: enable CLI-related lua-Harness tests back X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! On 25.02.24, Maxim Kokryashkin wrote: > Hi, Igor! > Thanks for the patch! > LGTM after fixing comments below. > On Sun, Feb 25, 2024 at 10:41:07AM +0000, Igor Munkin wrote: > > Tarantool supports -b and -j options to use LuaJIT modules since the > > commit bf8b76a4dfc9dd62d4131e90e2ae5d83843b6630 ("lua: proxy -j and -b > > flags"), so 241-standalone.t and 411-luajit.t tests in lua-Harness > Typo: s/in lua-Harness/in the lua-Harness/ Fixed, thanks! > > suite, disabled in the commit 39a4db500db2619359c2c9474be016360252060d > > ("test: support Tarantool in lua-Harness"), can be enabled back. > > > > However, -O options is still not implemented in Tarantool, so the > Typo: s/is still/are still/ There is another typo: s/options/option/. Fixed, thanks! > > related part in 411-luajit.t test chunk is still disabled. > Typo: s/in/in the/ Fixed, thanks! > > > > Follows up #5541 > Typo: s/#5541/tarantool/tarantool#5541/ Oops, fixed, thanks! Side note: you can use another separator to avoid escaping the /. E.g. braces: s{#5541}{tarantool/tarantool#5541}. However, I'm not a robot, so the comment is still clear to me ;) > > > > Signed-off-by: Igor Munkin > > --- > > test/lua-Harness-tests/241-standalone.t | 2 +- > > test/lua-Harness-tests/411-luajit.t | 6 ++++-- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > -- > > 2.39.2 > > -- Best regards, IM