Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] test: enable CLI-related lua-Harness tests back
Date: Sun, 25 Feb 2024 19:41:31 +0000	[thread overview]
Message-ID: <ZduX63TeNxJs_1_M@tarantool.org> (raw)
In-Reply-To: <ZduVr6q1udQDx_Cx@tarantool.org>

Max,

Thanks for your **review**! I've fixed all the nits you've left, the branch
is force-pushed.

Side note: I guess I made very little patches and merged too many series
for the last year considering the typo below...

On 25.02.24, Igor Munkin via Tarantool-patches wrote:
> Max,
> 
> Thanks for the patch!
                 ^^^^^
> 

<snipped>

> 
> Oops, fixed, thanks!
> 
> Side note: you can use another separator to avoid escaping the /. E.g.
> braces: s{#5541}{tarantool/tarantool#5541}. However, I'm not a robot, so
                                                       ^^^^^^^^^^^^^^^
                                                       ... or am I?
> the comment is still clear to me ;)
> 

<snipped>

> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM

  reply	other threads:[~2024-02-25 19:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-25 10:41 [Tarantool-patches] [PATCH luajit 0/2] Enable CLI-related tests in lua-Harness Igor Munkin via Tarantool-patches
2024-02-25 10:41 ` [Tarantool-patches] [PATCH luajit 1/2] test: introduce routine to build error message Igor Munkin via Tarantool-patches
2024-02-25 11:37   ` Maxim Kokryashkin via Tarantool-patches
2024-02-25 19:27     ` Igor Munkin via Tarantool-patches
2024-02-25 10:41 ` [Tarantool-patches] [PATCH luajit 2/2] test: enable CLI-related lua-Harness tests back Igor Munkin via Tarantool-patches
2024-02-25 11:41   ` Maxim Kokryashkin via Tarantool-patches
2024-02-25 19:31     ` Igor Munkin via Tarantool-patches
2024-02-25 19:41       ` Igor Munkin via Tarantool-patches [this message]
2024-02-27  8:36 ` [Tarantool-patches] [PATCH luajit 0/2] Enable CLI-related tests in lua-Harness Sergey Kaplun via Tarantool-patches
2024-02-28 18:25 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZduX63TeNxJs_1_M@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] test: enable CLI-related lua-Harness tests back' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox