Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
	Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/2] Enable CLI-related tests in lua-Harness
Date: Sun, 25 Feb 2024 10:41:05 +0000	[thread overview]
Message-ID: <cover.1708856482.git.imun@tarantool.org> (raw)

There are two reasons to apply this series to the trunk:

1. The positive one: Tarantool supports -b and -j options to use LuaJIT
modules since the commit bf8b76a4dfc9dd62d4131e90e2ae5d83843b6630 ("lua:
proxy -j and -b flags"), so the related tests from lua-Harness suite can
be partially (since -O is still not implemented in Tarantool) enabled.

2. The negative one: Tarantool diff-based tests for CLI interfaces are
hard to maintain if any change occurrs in LuaJIT modules, since the
aforementioned tests implement dumb comparison of the output, produced
by the current CLI version against the expected one, provided by the
.result file. Hence, to rule the tests related to LuaJIT CLI interface
in a more convenient way, the corresponding tests should be moved from
the tests in Tarantool repository to the tests in LuaJIT repository. The
branch enables the nice checks implemented in the lua-Harness suite; the
PR #9726 removes the unmaintainable diff-based tests in Tarantool repo.

The changeset is split into the two patches. One can find more reasoning
within the particular commit message.

Branch: https://github.com/tarantool/luajit/tree/imun/enable-tarantool-cli-tests-in-lua-Harness
Tarantool PR(*): https://github.com/tarantool/tarantool/pull/9726

(*) There is a Tarantool-related patch on top of the corresponding
LuaJIT bump.

Igor Munkin (2):
  test: introduce routine to build error message
  test: enable CLI-related lua-Harness tests back

 test/lua-Harness-tests/241-standalone.t |  2 +-
 test/lua-Harness-tests/411-luajit.t     | 23 +++++++++++++++++------
 2 files changed, 18 insertions(+), 7 deletions(-)

-- 
2.39.2


             reply	other threads:[~2024-02-25 10:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-25 10:41 Igor Munkin via Tarantool-patches [this message]
2024-02-25 10:41 ` [Tarantool-patches] [PATCH luajit 1/2] test: introduce routine to build error message Igor Munkin via Tarantool-patches
2024-02-25 11:37   ` Maxim Kokryashkin via Tarantool-patches
2024-02-25 19:27     ` Igor Munkin via Tarantool-patches
2024-02-25 10:41 ` [Tarantool-patches] [PATCH luajit 2/2] test: enable CLI-related lua-Harness tests back Igor Munkin via Tarantool-patches
2024-02-25 11:41   ` Maxim Kokryashkin via Tarantool-patches
2024-02-25 19:31     ` Igor Munkin via Tarantool-patches
2024-02-25 19:41       ` Igor Munkin via Tarantool-patches
2024-02-27  8:36 ` [Tarantool-patches] [PATCH luajit 0/2] Enable CLI-related tests in lua-Harness Sergey Kaplun via Tarantool-patches
2024-02-28 18:25 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1708856482.git.imun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Enable CLI-related tests in lua-Harness' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox