From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring
Date: Thu, 8 Apr 2021 15:21:37 +0300 [thread overview]
Message-ID: <YG71UeQryjXv22vk@grain> (raw)
In-Reply-To: <20210408121813.1633911-1-gorcunov@gmail.com>
On Thu, Apr 08, 2021 at 03:18:13PM +0300, Cyrill Gorcunov wrote:
> +static int
> +lbox_info_synchro(struct lua_State *L)
> +{
> + lua_createtable(L, 0, 2);
> +
> + /* Quorum value may be evaluated via formula */
> + lua_pushinteger(L, replication_synchro_quorum);
> + lua_setfield(L, -2, "quorum");
> +
> + /*Queue information. */
Missing whitespace after the opening comment. Force pushed update.
Also what is changed since v3:
- use lua_createtable
- move test to qsync_basic
next prev parent reply other threads:[~2021-04-08 12:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 12:18 Cyrill Gorcunov via Tarantool-patches
2021-04-08 12:21 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-04-08 12:58 ` Serge Petrenko via Tarantool-patches
2021-04-08 13:13 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 13:15 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 13:17 ` Serge Petrenko via Tarantool-patches
2021-04-08 13:23 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 14:57 ` [Tarantool-patches] [PATCH v5] " Cyrill Gorcunov via Tarantool-patches
2021-04-08 15:24 ` Serge Petrenko via Tarantool-patches
2021-04-09 22:24 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-12 5:59 ` [Tarantool-patches] [PATCH v4] " Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG71UeQryjXv22vk@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox