From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BE7BE6EC5D; Thu, 8 Apr 2021 15:21:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BE7BE6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617884501; bh=OPmRhxIRd4VZNRZb7rZt2ztoKAN9vu4vgSCtw7sbzmw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fD35buOGGrvS1z1VyDJ9fK3s5kbQXINvNNT8Xmy3M4Hc5SW2zM6ZwZvFiRcB12U1x 1KFQpUokgsT07QnoIh0CNTb+0GAYfsAeIQ/WxV/MgHC+zCoA0ZLpaFbbrLVFOme5bT 1pxbzh4oq1xYDR3CQ1jffZYe5HurRU7gu1Z0v6Mg= Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0F15A6EC5D for ; Thu, 8 Apr 2021 15:21:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F15A6EC5D Received: by mail-lf1-f51.google.com with SMTP id w28so3670272lfn.2 for ; Thu, 08 Apr 2021 05:21:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9nurO3zF86VENbtQ/qI80O5AQaGueDebBVlzzjYfmZw=; b=frXECTcWg6ofJNN4VGR7pMZwi3aYWl8e3zxYLRsPfgAwLTWJBvIBJWUn6Oq6u888Se 20JwelEz9EQd6klcOsdtc01V7MRYnD2jL/k/BZxiVM2hQD9o7+tNkuLGhovvnQUeoZJ6 ZTE3kAVXY4ey+xJkWUuDet0VG/p404NL3O+UpUwLVVFiK3+1UNLV+6DJlLFF9GgrRgoe qNjoIMnFPi0sQWgx9PKZX0jkSuQUKV+tgBAWvDeNqh4LolNvE4SB3zytJ3vaN2rZu8UH yOCjCaB2u+XCvhdNLWV0J0o0AOWJolzJ9FxVtkdBEjK2nza+ooRYPY+JnPnnOJZTxh+E RfMg== X-Gm-Message-State: AOAM5331CljB46j+7Ca9Pps9UKknSpeGKl+GIkHJj9PQ2JbgCb3c4Jft 2pFtOWdoaHYxw0PcOELgh5fVEp25KFg= X-Google-Smtp-Source: ABdhPJy0F1Up1xOxq5+HudqOfF2j01GnrVgXCDox20bZnU/XLHH+iiN8NBApd3ocU12V6rkh6+rl7Q== X-Received: by 2002:a05:6512:2189:: with SMTP id b9mr5925622lft.640.1617884499994; Thu, 08 Apr 2021 05:21:39 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id q12sm603945lfd.71.2021.04.08.05.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 05:21:38 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 021C256015C; Thu, 8 Apr 2021 15:21:38 +0300 (MSK) Date: Thu, 8 Apr 2021 15:21:37 +0300 To: tml Message-ID: References: <20210408121813.1633911-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408121813.1633911-1-gorcunov@gmail.com> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Apr 08, 2021 at 03:18:13PM +0300, Cyrill Gorcunov wrote: > +static int > +lbox_info_synchro(struct lua_State *L) > +{ > + lua_createtable(L, 0, 2); > + > + /* Quorum value may be evaluated via formula */ > + lua_pushinteger(L, replication_synchro_quorum); > + lua_setfield(L, -2, "quorum"); > + > + /*Queue information. */ Missing whitespace after the opening comment. Force pushed update. Also what is changed since v3: - use lua_createtable - move test to qsync_basic