From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com> Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring Date: Thu, 8 Apr 2021 16:17:23 +0300 [thread overview] Message-ID: <226c4c61-7174-1789-ffc6-64fdb1bbc642@tarantool.org> (raw) In-Reply-To: <YG8BZdXGEC80OVRk@grain> 08.04.2021 16:13, Cyrill Gorcunov пишет: > On Thu, Apr 08, 2021 at 03:58:38PM +0300, Serge Petrenko wrote: >> 08.04.2021 15:18, Cyrill Gorcunov пишет: >>> In commit 14fa5fd82 (cfg: support symbolic evaluation of >>> replication_synchro_quorum) we implemented support of >>> symbolic evaluation of `replication_synchro_quorum` parameter >>> and there is no easy way to obtain it current run-time value, >>> ie evaluated number value. >>> >>> Moreover we would like to fetch queue length on transaction >>> limbo for tests and extend this statistics in future. Thus >>> lets add them. >>> >>> Closes #5191 >> Thanks for the fixes! >> >> Please return `box.info.synchro.quorum` assertions to the >> test regarding quorum evaluation. Like you had it in the >> previous patch version. >> > Say like this? Yes, but better do it in the test `replication/gh-5446-qsync-eval-quorum` > --- > diff --git a/test/replication/qsync_basic.result b/test/replication/qsync_basic.result > index 3457d2cc9..985a5baff 100644 > --- a/test/replication/qsync_basic.result > +++ b/test/replication/qsync_basic.result > @@ -653,6 +653,13 @@ test_run:cmd('switch default') > | --- > | - true > | ... > +box.cfg{ replication_synchro_quorum = "N/2+1" } > + | --- > + | ... > +assert(box.info.synchro.quorum == 2) > + | --- > + | - true > + | ... > test_run:cmd('stop server replica') > | --- > | - true > diff --git a/test/replication/qsync_basic.test.lua b/test/replication/qsync_basic.test.lua > index a604d80ee..a1787648f 100644 > --- a/test/replication/qsync_basic.test.lua > +++ b/test/replication/qsync_basic.test.lua > @@ -261,6 +261,8 @@ box.space.sync:count() > -- and do not switch to other nodes. > -- > test_run:cmd('switch default') > +box.cfg{ replication_synchro_quorum = "N/2+1" } > +assert(box.info.synchro.quorum == 2) > test_run:cmd('stop server replica') > assert(box.info.synchro.queue.len == 0) > box.cfg{replication_synchro_timeout = 2} -- Serge Petrenko
next prev parent reply other threads:[~2021-04-08 13:17 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-08 12:18 Cyrill Gorcunov via Tarantool-patches 2021-04-08 12:21 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 12:58 ` Serge Petrenko via Tarantool-patches 2021-04-08 13:13 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 13:15 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 13:17 ` Serge Petrenko via Tarantool-patches [this message] 2021-04-08 13:23 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 14:57 ` [Tarantool-patches] [PATCH v5] " Cyrill Gorcunov via Tarantool-patches 2021-04-08 15:24 ` Serge Petrenko via Tarantool-patches 2021-04-09 22:24 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-12 5:59 ` [Tarantool-patches] [PATCH v4] " Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=226c4c61-7174-1789-ffc6-64fdb1bbc642@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox