From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DF8FF6EC5D; Thu, 8 Apr 2021 16:17:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DF8FF6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617887847; bh=x7qRC+fDPZwYAdYJhOzWCF43F/vdG2Ph6xmG3YZPeG4=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OfsGil0ljDbSKAu8rtDUmVm87R5Tn5nSCZF6JOhGsrahlX/ewUC7G8nIlVLckYK16 vK6julYq2RKj6iEnNDWJxXApgv6a9XeJWd5DDYrzqBigKF///AHSS4jqUw7p+3ztP+ ArvqoGbsdz0XMcK9bO0PRi1f9sfvETZYn1Unjwes= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D393C6EC5D for ; Thu, 8 Apr 2021 16:17:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D393C6EC5D Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1lUUXE-00066B-Kz; Thu, 08 Apr 2021 16:17:25 +0300 To: Cyrill Gorcunov References: <20210408121813.1633911-1-gorcunov@gmail.com> <75632023-f2e4-b038-f800-990181566e64@tarantool.org> Message-ID: <226c4c61-7174-1789-ffc6-64fdb1bbc642@tarantool.org> Date: Thu, 8 Apr 2021 16:17:23 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC1FEA0A53B931EDD909DE4D58F47F062C400894C459B0CD1B9F8B1CBCDD828A6942D17004C1C71EA5E9CED15513CB2F15646A9EDC33AB89B9D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CE54A8686262D0D1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AAEFEF2B38A4D0058638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2ADF6F478B256DAAA09436B7DC66342E851ACFDFAE348AC99D2E47CDBA5A96583C09775C1D3CA48CFE478A468B35FE767117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F249797B4B1AC1449CE5475246E174218B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5307A25D426795BC91EC2A640C4EE68AA4C09E1AF58FA9242D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341776B9FDE05FBA7A13908800ED9F15EF510AC76EB4568335F0EFDA8FBD46ACDEFAF6FA784A5F92AE1D7E09C32AA3244C1BACCAC183AEF67491C9AB6B09708DA18580396430872480927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXrmY+RbGrU7zw== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A446D5C924B680FEF5BFF8672DA21CF79AA07DAF9310E7C83EE3424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 08.04.2021 16:13, Cyrill Gorcunov пишет: > On Thu, Apr 08, 2021 at 03:58:38PM +0300, Serge Petrenko wrote: >> 08.04.2021 15:18, Cyrill Gorcunov пишет: >>> In commit 14fa5fd82 (cfg: support symbolic evaluation of >>> replication_synchro_quorum) we implemented support of >>> symbolic evaluation of `replication_synchro_quorum` parameter >>> and there is no easy way to obtain it current run-time value, >>> ie evaluated number value. >>> >>> Moreover we would like to fetch queue length on transaction >>> limbo for tests and extend this statistics in future. Thus >>> lets add them. >>> >>> Closes #5191 >> Thanks for the fixes! >> >> Please return `box.info.synchro.quorum` assertions to the >> test regarding quorum evaluation. Like you had it in the >> previous patch version. >> > Say like this? Yes, but better do it in the test `replication/gh-5446-qsync-eval-quorum` > --- > diff --git a/test/replication/qsync_basic.result b/test/replication/qsync_basic.result > index 3457d2cc9..985a5baff 100644 > --- a/test/replication/qsync_basic.result > +++ b/test/replication/qsync_basic.result > @@ -653,6 +653,13 @@ test_run:cmd('switch default') > | --- > | - true > | ... > +box.cfg{ replication_synchro_quorum = "N/2+1" } > + | --- > + | ... > +assert(box.info.synchro.quorum == 2) > + | --- > + | - true > + | ... > test_run:cmd('stop server replica') > | --- > | - true > diff --git a/test/replication/qsync_basic.test.lua b/test/replication/qsync_basic.test.lua > index a604d80ee..a1787648f 100644 > --- a/test/replication/qsync_basic.test.lua > +++ b/test/replication/qsync_basic.test.lua > @@ -261,6 +261,8 @@ box.space.sync:count() > -- and do not switch to other nodes. > -- > test_run:cmd('switch default') > +box.cfg{ replication_synchro_quorum = "N/2+1" } > +assert(box.info.synchro.quorum == 2) > test_run:cmd('stop server replica') > assert(box.info.synchro.queue.len == 0) > box.cfg{replication_synchro_timeout = 2} -- Serge Petrenko