Re: [Tarantool-patches] [PATCH luajit v2 0/2] Make build improvements

Re: [Tarantool-patches] [PATCH luajit v2 0/2] Make build improvements

[Igor Munkin via Tarantool-patches]

Sergey,

Thanks for your patches! LGTM.

I've reimplemented CI workflow a bit by merging two checks (CMake and
Makefile.original) into a single job to reduce pressure on the runners
(additional clone, setup, etc is not needed).

I've checked both patches into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.

On 25.10.22, Sergey Kaplun wrote:
> The first patch fixes the build via <Makefile.original>.
> The second patch adds CI for the CMake GNU Make build, that will become
> obsolete after using Ninja for `Testing` workflow.
> 
> See runs examples here:
> https://github.com/tarantool/luajit/actions/workflows/gnumake-bulds.yml
> Branch:
> https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-make-build-full-ci
> 
> Sergey Kaplun (2):
>   build: fix build with original Makefile
>   ci: add workflow for legacy CMake GNU Make build
> 
>  .github/actions/setup-macos/action.yml |   8 ++
>  .github/workflows/gnumake-bulds.yml    | 151 +++++++++++++++++++++++++
>  src/Makefile.dep.original              |   7 +-
>  src/Makefile.original                  |   7 +-
>  4 files changed, 167 insertions(+), 6 deletions(-)
>  create mode 100644 .github/workflows/gnumake-bulds.yml
> 
> -- 
> 2.34.1
> 

-- 
Best regards,
IM