From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0D26C288C6; Fri, 11 Nov 2022 12:09:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D26C288C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1668157781; bh=FOewEsyvWf3Rj2Lfai6BUYSCWIFyjnmG/TvsSQPbXt0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=baoARXGGzmfxuKD6FEWUDC7FZvHzgZ1Wa0lGwqLVWUNPykisHyxzzcjut0+GdlNnb K0FhiMdHkWGMriNlDW8qYlqK7Yf3QfwzJOA9U5ilsjLvQGL0ctpwK2925Jp6qt0kUJ a1wG2pDGAbE2cREWmPdltaT6IgaQR997/hTDnZQ0= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8DC3E288C5 for ; Fri, 11 Nov 2022 12:09:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8DC3E288C5 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1otQ2D-0002TA-Q1; Fri, 11 Nov 2022 12:09:14 +0300 Date: Fri, 11 Nov 2022 11:56:33 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9143903447CF85CF5092F15731B949002ECF52CCFBA4658E0182A05F5380850404C228DA9ACA6FE27504B8351BE10278BE5DBC3BC2E3422E63A743A611793FCFCBBB1E057AF8D9106 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79B4AFF82F0254274EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BA5555A0C16230F4EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BA10283F7DADCE9971ECAA99F928BE4CEACC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDC5C53491350371F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BEB1A37DF9DABAA8F75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F1257DC9690AEBA16BC8A776A6DDE7F0375EEC2730A4E4A729963E8D8E446062EFEB676E88D696521D7E09C32AA3244C581CE139C1E7EE26BC93CAB9AED3FC6933C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSqkc8Nj21UPrZil5r8dBgQ== X-DA7885C5: F9AB4B8CEE12D9A1AFBD198FD00533A5A440AB8BBC0A914A0CDEB35809902CDC262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EDD64EAEE3178B1A196E61AE4C6D65D65A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 0/2] Make build improvements X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your patches! LGTM. I've reimplemented CI workflow a bit by merging two checks (CMake and Makefile.original) into a single job to reduce pressure on the runners (additional clone, setup, etc is not needed). I've checked both patches into all long-term branches in tarantool/luajit and bumped a new version in master, 2.10 and 1.10. On 25.10.22, Sergey Kaplun wrote: > The first patch fixes the build via . > The second patch adds CI for the CMake GNU Make build, that will become > obsolete after using Ninja for `Testing` workflow. > > See runs examples here: > https://github.com/tarantool/luajit/actions/workflows/gnumake-bulds.yml > Branch: > https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-make-build-full-ci > > Sergey Kaplun (2): > build: fix build with original Makefile > ci: add workflow for legacy CMake GNU Make build > > .github/actions/setup-macos/action.yml | 8 ++ > .github/workflows/gnumake-bulds.yml | 151 +++++++++++++++++++++++++ > src/Makefile.dep.original | 7 +- > src/Makefile.original | 7 +- > 4 files changed, 167 insertions(+), 6 deletions(-) > create mode 100644 .github/workflows/gnumake-bulds.yml > > -- > 2.34.1 > -- Best regards, IM