Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2 0/2] Make build improvements
Date: Fri, 11 Nov 2022 11:56:33 +0300	[thread overview]
Message-ID: <Y24OQRS4jy8bTAPg@tarantool.org> (raw)
In-Reply-To: <cover.1666688011.git.skaplun@tarantool.org>


Thanks for your patches! LGTM.

I've reimplemented CI workflow a bit by merging two checks (CMake and
Makefile.original) into a single job to reduce pressure on the runners
(additional clone, setup, etc is not needed).

I've checked both patches into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.

On 25.10.22, Sergey Kaplun wrote:
> The first patch fixes the build via <Makefile.original>.
> The second patch adds CI for the CMake GNU Make build, that will become
> obsolete after using Ninja for `Testing` workflow.
> See runs examples here:
> https://github.com/tarantool/luajit/actions/workflows/gnumake-bulds.yml
> Branch:
> https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-make-build-full-ci
> Sergey Kaplun (2):
>   build: fix build with original Makefile
>   ci: add workflow for legacy CMake GNU Make build
>  .github/actions/setup-macos/action.yml |   8 ++
>  .github/workflows/gnumake-bulds.yml    | 151 +++++++++++++++++++++++++
>  src/Makefile.dep.original              |   7 +-
>  src/Makefile.original                  |   7 +-
>  4 files changed, 167 insertions(+), 6 deletions(-)
>  create mode 100644 .github/workflows/gnumake-bulds.yml
> -- 
> 2.34.1

Best regards,

           reply	other threads:[~2022-11-11  9:09 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <cover.1666688011.git.skaplun@tarantool.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y24OQRS4jy8bTAPg@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2 0/2] Make build improvements' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox