Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c
Date: Tue, 30 Nov 2021 22:00:44 +0100	[thread overview]
Message-ID: <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> (raw)
In-Reply-To: <2746684244053070165bf106f754866fea02096e.1637756342.git.imeevma@gmail.com>

Hi! Thanks for the patch looks good, but I would drop this 'register trace'
entirely. Everything that uses 'printf' is dead anyway.

LGTM. Drop more code or send this patch further, does not matter.

  reply	other threads:[~2021-11-30 21:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 12:22 Mergen Imeev via Tarantool-patches
2021-11-30 21:00 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-12-01  7:59   ` Mergen Imeev via Tarantool-patches
2021-12-02 23:46     ` Vladislav Shpilevoy via Tarantool-patches
2021-12-03 14:48       ` Mergen Imeev via Tarantool-patches
2021-12-01  8:06 Mergen Imeev via Tarantool-patches
2021-12-02 10:42 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox