From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c Date: Wed, 1 Dec 2021 10:59:40 +0300 [thread overview] Message-ID: <20211201075940.GA29482@tarantool.org> (raw) In-Reply-To: <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> Hi! Thank you for the review! My answer below. On Tue, Nov 30, 2021 at 10:00:44PM +0100, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch looks good, but I would drop this 'register trace' > entirely. Everything that uses 'printf' is dead anyway. > I'm not sure about that. For example, I have executed these statements on master and on my branch: box.execute('set session "sql_vdbe_debug" = true;') box.execute([[select 1;]]) Result on master: SQL: [select 1;] VDBE Program Listing: 103> 0 Init 0 1 0 00 Start at 1 103> 1 Integer 1 1 0 00 r[1]=1 103> 2 ResultRow 1 1 0 00 output=r[1] 103> 3 Halt 0 0 0 00 VDBE Trace: 103> 0 Init 0 1 0 00 Start at 1 SQL-trace: select 1; 103> 1 Integer 1 1 0 00 r[1]=1 REG[1] = u:1 103> 2 ResultRow 1 1 0 00 output=r[1] REG[1] = u:1 103> 3 Halt 0 0 0 00 --- - metadata: - name: COLUMN_1 type: integer rows: - [1] ... Result on the branch: SQL: [select 1;] VDBE Program Listing: 103> 0 Init 0 1 0 00 Start at 1 103> 1 Integer 1 1 0 00 r[1]=1 103> 2 ResultRow 1 1 0 00 output=r[1] 103> 3 Halt 0 0 0 00 VDBE Trace: 103> 0 Init 0 1 0 00 Start at 1 SQL-trace: select 1; 103> 1 Integer 1 1 0 00 r[1]=1 REG[1] = integer(1) 103> 2 ResultRow 1 1 0 00 output=r[1] REG[1] = integer(1) 103> 3 Halt 0 0 0 00 --- - metadata: - name: COLUMN_1 type: integer rows: - [1] ... As you can see, the contents of REG[1] are displayed differently. > LGTM. Drop more code or send this patch further, does not matter.
next prev parent reply other threads:[~2021-12-01 7:59 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-24 12:22 Mergen Imeev via Tarantool-patches 2021-11-30 21:00 ` Vladislav Shpilevoy via Tarantool-patches 2021-12-01 7:59 ` Mergen Imeev via Tarantool-patches [this message] 2021-12-02 23:46 ` Vladislav Shpilevoy via Tarantool-patches 2021-12-03 14:48 ` Mergen Imeev via Tarantool-patches 2021-12-01 8:06 Mergen Imeev via Tarantool-patches 2021-12-02 10:42 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211201075940.GA29482@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imeevma@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox