From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 03DD371065; Wed, 1 Dec 2021 10:59:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03DD371065 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638345584; bh=Lw1a/Nu+HesvMFavrjODwTr9UYOTlJc/6le7haH8yZM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ppJ8R6okgLUDppB4PdFJ3vYPodGTNpZehOwUlQBoEGy6xOl+Rrez5QA4Gbs3dGhsz v2mqrNFA+1HUexeddq6TLnjBXIhHfzQKdNqacHgGt2aOx6qGLjdubNkdE+JDdL5q0n 7+VWjsEioaIlYZ+XSSiSu0PwcVGJXQtjBytJU34M= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AA88B71065 for ; Wed, 1 Dec 2021 10:59:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AA88B71065 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1msKWj-0006Lb-Q9; Wed, 01 Dec 2021 10:59:42 +0300 Date: Wed, 1 Dec 2021 10:59:40 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20211201075940.GA29482@tarantool.org> References: <2746684244053070165bf106f754866fea02096e.1637756342.git.imeevma@gmail.com> <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979319CBFD1B938ABBB2665FB0C120F218BD264C08710B407182A05F538085040AC77159261CDB84D3CB0C5554B618EA8FCDDCE93523FB594E08257863902C58C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374A24022C550661178638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D08C56664B4F48D6D878E0581791C3EF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A52F962099D8A21F8322643E4A11936F88F68C2B7F31DABD0ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759F66ED85EB5F25FD410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347130F804358653A6B70910CF56D6BF28A3B8744C0D1538F91726353A3DA6625D39EEB770F3E0BC911D7E09C32AA3244C5976A3965897B743C9E4DCC4BD05CF745595C85A795C7BAE729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLBs75AcgWjOaDpMZRexvDQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DD735202F6BCF85F8B7B054E537F7A57383D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the review! My answer below. On Tue, Nov 30, 2021 at 10:00:44PM +0100, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch looks good, but I would drop this 'register trace' > entirely. Everything that uses 'printf' is dead anyway. > I'm not sure about that. For example, I have executed these statements on master and on my branch: box.execute('set session "sql_vdbe_debug" = true;') box.execute([[select 1;]]) Result on master: SQL: [select 1;] VDBE Program Listing: 103> 0 Init 0 1 0 00 Start at 1 103> 1 Integer 1 1 0 00 r[1]=1 103> 2 ResultRow 1 1 0 00 output=r[1] 103> 3 Halt 0 0 0 00 VDBE Trace: 103> 0 Init 0 1 0 00 Start at 1 SQL-trace: select 1; 103> 1 Integer 1 1 0 00 r[1]=1 REG[1] = u:1 103> 2 ResultRow 1 1 0 00 output=r[1] REG[1] = u:1 103> 3 Halt 0 0 0 00 --- - metadata: - name: COLUMN_1 type: integer rows: - [1] ... Result on the branch: SQL: [select 1;] VDBE Program Listing: 103> 0 Init 0 1 0 00 Start at 1 103> 1 Integer 1 1 0 00 r[1]=1 103> 2 ResultRow 1 1 0 00 output=r[1] 103> 3 Halt 0 0 0 00 VDBE Trace: 103> 0 Init 0 1 0 00 Start at 1 SQL-trace: select 1; 103> 1 Integer 1 1 0 00 r[1]=1 REG[1] = integer(1) 103> 2 ResultRow 1 1 0 00 output=r[1] REG[1] = integer(1) 103> 3 Halt 0 0 0 00 --- - metadata: - name: COLUMN_1 type: integer rows: - [1] ... As you can see, the contents of REG[1] are displayed differently. > LGTM. Drop more code or send this patch further, does not matter.