Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c
Date: Fri, 3 Dec 2021 17:48:46 +0300	[thread overview]
Message-ID: <20211203144846.GA199443@tarantool.org> (raw)
In-Reply-To: <6f9b09b0-65d2-2f81-8316-5f2940a35100@tarantool.org>

On Fri, Dec 03, 2021 at 12:46:34AM +0100, Vladislav Shpilevoy wrote:
> On 01.12.2021 08:59, Mergen Imeev via Tarantool-patches wrote:
> > Hi! Thank you for the review! My answer below.
> > 
> > On Tue, Nov 30, 2021 at 10:00:44PM +0100, Vladislav Shpilevoy wrote:
> >> Hi! Thanks for the patch looks good, but I would drop this 'register trace'
> >> entirely. Everything that uses 'printf' is dead anyway.
> >>
> > I'm not sure about that. For example, I have executed these statements on master and on my branch:
> It is a misunderstanding. I didn't mean you patch does not
> change anything. I meant that this whole mechanism of 'register traces'
> is dead IMO. It is unusable. For example, if you need to debug something
> on a remote server, you won't see these printf() results anyway. Because
> you perhaps will talk to the server using IProto. So whatever the server
> prints to stdout you simply won't see. You will use box.execute EXPLAIN,
> right?
> As 'dead' here I meant useless/unusable/not-worth-the-efforts-of-fixing.
> Not unreachable.
Thank you for the explanation! I will think about what we can do to replace
this functionality by something more useful.

  reply	other threads:[~2021-12-03 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 12:22 Mergen Imeev via Tarantool-patches
2021-11-30 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-12-01  7:59   ` Mergen Imeev via Tarantool-patches
2021-12-02 23:46     ` Vladislav Shpilevoy via Tarantool-patches
2021-12-03 14:48       ` Mergen Imeev via Tarantool-patches [this message]
2021-12-01  8:06 Mergen Imeev via Tarantool-patches
2021-12-02 10:42 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203144846.GA199443@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox