From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5033E70297; Fri, 3 Dec 2021 17:48:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5033E70297 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638542929; bh=K+xTolL0HRj4kah5ERvpn9js2O/pLVH4v7u3l6uCOSQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=oTkoyfOccNNdJY3Rc03d1FE4EldAtl0qOV7N91Zvqe/VYO0K7Q5iG4kDiCwOwjjMX rGlw5gF/QBrVsszUUKe+JN4laI10Tbc65dYsQldniXFoA8Ino7NDoR+MUrlJKEgmvf gj6i6UAbMNXDh+zkRuHfc1gGd7EvV8pMxDTa/MNA= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4524070297 for ; Fri, 3 Dec 2021 17:48:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4524070297 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mt9rj-0005C9-JO; Fri, 03 Dec 2021 17:48:47 +0300 Date: Fri, 3 Dec 2021 17:48:46 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20211203144846.GA199443@tarantool.org> References: <2746684244053070165bf106f754866fea02096e.1637756342.git.imeevma@gmail.com> <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> <20211201075940.GA29482@tarantool.org> <6f9b09b0-65d2-2f81-8316-5f2940a35100@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6f9b09b0-65d2-2f81-8316-5f2940a35100@tarantool.org> X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93822B471089FF64D73F8BCC4B84AFC96045BB84450516CBB182A05F5380850404FCEE28CD3485D0AD6280F4582B5EC13E5E8FD272D2FE5B93EFDF7CBEE44BFF9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D99F96657F58F1038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D805A442863C9B756594E57A6738A02C7E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A59A20A4371DBFF072588C96B524AD9D95C0062550EDD000CBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7506FE1F977233B9BB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345C110A855FC099996A731602A618915E56467A453E977A12BE97A20F38D8265BFF938400BC0668F01D7E09C32AA3244C360FA63B8BFACFE9E138250C70CE184364EE5813BBCA3A9D729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+/8mdklYaigd0oGcaPwaAA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D4E69FA43ED879F071F07117E9104E15B83D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Dec 03, 2021 at 12:46:34AM +0100, Vladislav Shpilevoy wrote: > On 01.12.2021 08:59, Mergen Imeev via Tarantool-patches wrote: > > Hi! Thank you for the review! My answer below. > > > > On Tue, Nov 30, 2021 at 10:00:44PM +0100, Vladislav Shpilevoy wrote: > >> Hi! Thanks for the patch looks good, but I would drop this 'register trace' > >> entirely. Everything that uses 'printf' is dead anyway. > >> > > I'm not sure about that. For example, I have executed these statements on master and on my branch: > > It is a misunderstanding. I didn't mean you patch does not > change anything. I meant that this whole mechanism of 'register traces' > is dead IMO. It is unusable. For example, if you need to debug something > on a remote server, you won't see these printf() results anyway. Because > you perhaps will talk to the server using IProto. So whatever the server > prints to stdout you simply won't see. You will use box.execute EXPLAIN, > right? > > As 'dead' here I meant useless/unusable/not-worth-the-efforts-of-fixing. > Not unreachable. Thank you for the explanation! I will think about what we can do to replace this functionality by something more useful.