From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7141A70295; Wed, 1 Dec 2021 00:00:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7141A70295 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638306048; bh=kFO+aQL5H58daxMmUc2Knifbl/TFlu4QJuzB5h9nnlk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=yGQ2Svt7vIivzoEmkFd8jjesCeVqhoGH0fTe9k3UK1Irhfzd0887T9x8BueeM8/wM jcizAJWW0LH1jsTd3bbhCZdupvKY0t0DlATk//45W3zOXqhm7Z7rJz+Fxgu9EsjbjG 7XOqi/8loWuhhw6Iy/BPvOqZJLRXyRRq7sjUFAQ8= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1F7F170295 for ; Wed, 1 Dec 2021 00:00:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1F7F170295 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1msAF4-0002Tx-DY; Wed, 01 Dec 2021 00:00:46 +0300 Message-ID: <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> Date: Tue, 30 Nov 2021 22:00:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-US To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <2746684244053070165bf106f754866fea02096e.1637756342.git.imeevma@gmail.com> In-Reply-To: <2746684244053070165bf106f754866fea02096e.1637756342.git.imeevma@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979319CBFD1B938ABBB2665FB0C120F218BD264C08710B407182A05F53808504047BB537FB894CEEC41A401036F02288B2BAE76B56A163897177088BEA1D97890 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D08D652E28591A78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A7DC4B1CB24C787D1E84402EBEBD6326117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5573D659D6C40C6F3BA2D3A3CD4DD5686B18436F520C73206D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759F66ED85EB5F25FD410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9873270276D4334E6E8ACB2728D237E155D687702D572F6CCE61266ECB0A0105C61A0F12030170E1D7E09C32AA3244C92472348873A6BDCCCE57F4E05471B389CA7333006C390A0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLBs75AcgWjNZy7t0Fb5ipg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF7321217FD4D39D5B6C8C8DDCA63B5F43841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch looks good, but I would drop this 'register trace' entirely. Everything that uses 'printf' is dead anyway. LGTM. Drop more code or send this patch further, does not matter.