From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 00/11] qsync: code refactoring
Date: Sat, 21 Nov 2020 00:54:54 +0100 [thread overview]
Message-ID: <64dc89a9-22bc-56d9-2e4c-4cfd5a508b27@tarantool.org> (raw)
In-Reply-To: <20201112195121.191366-1-gorcunov@gmail.com>
Hi! Thanks for the patchset!
I won't explain again (third or forth time, I don't remember), why
we don't do refactoring for the sake of refactoring. You can find it
in the mailing list and re-read, if you want. Sorry if sounds rude,
but I give up after explaining it so many times. So I will simply write
NACK for the commits, which literally don't do anything except
subjectively 'more readable' changes.
If you disagree, respond to my emails why concretely. It means you
can prove that the commit fixes a bug, or fixes some serious flaw in
the code style which makes the code look corrupted and totally
unreadable with wrong variable names etc, or it reduces some huge
code duplication. Other things are subjective.
Commits 2, 3, 5, 11 LGTM. I will commit them when the rest of the patches
are reviewed, discussed, and everyone agrees with the decisions.
next prev parent reply other threads:[~2020-11-20 23:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 19:51 Cyrill Gorcunov
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 01/11] build: add more ignore paths for tags target Cyrill Gorcunov
2020-11-16 13:09 ` Cyrill Gorcunov
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-21 12:09 ` Cyrill Gorcunov
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 02/11] vclock: vclock_get - drop misleading masking Cyrill Gorcunov
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 03/11] vclock: vclock_inc -- add assert() to catch overflow Cyrill Gorcunov
2020-11-13 9:30 ` Serge Petrenko
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 04/11] txn: txn_commit_async -- drop redundant variable Cyrill Gorcunov
2020-11-13 9:31 ` Serge Petrenko
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-21 12:30 ` Cyrill Gorcunov
2020-11-21 13:29 ` Vladislav Shpilevoy
2020-11-21 16:14 ` Cyrill Gorcunov
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 05/11] qsync: rename txn_limbo::instance_id to owner_id Cyrill Gorcunov
2020-11-13 9:37 ` Serge Petrenko
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 06/11] qsync: txn_limbo_append -- use owner_id in argument name Cyrill Gorcunov
2020-11-13 9:43 ` Serge Petrenko
2020-11-13 10:11 ` Cyrill Gorcunov
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 07/11] qsync: move limbo owner transition into separate helper Cyrill Gorcunov
2020-11-13 9:47 ` Serge Petrenko
2020-11-13 10:12 ` Cyrill Gorcunov
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 08/11] qsync: txn_limbo_wait_confirm -- refactor code a bit Cyrill Gorcunov
2020-11-13 9:56 ` Serge Petrenko
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 09/11] qsync: drop redundant type convention Cyrill Gorcunov
2020-11-13 10:11 ` Serge Petrenko
2020-11-13 10:13 ` Cyrill Gorcunov
2020-11-13 10:19 ` Serge Petrenko
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 10/11] relay: use verbose names for fibers Cyrill Gorcunov
2020-11-13 10:17 ` Serge Petrenko
2020-11-13 10:28 ` Cyrill Gorcunov
2020-11-20 23:55 ` Vladislav Shpilevoy
2020-11-12 19:51 ` [Tarantool-patches] [PATCH 11/11] raft: drop redundant argument Cyrill Gorcunov
2020-11-13 10:18 ` Serge Petrenko
2020-11-20 23:54 ` Vladislav Shpilevoy [this message]
2020-11-24 23:24 ` [Tarantool-patches] [PATCH 00/11] qsync: code refactoring Vladislav Shpilevoy
2020-11-23 23:26 ` Vladislav Shpilevoy
2020-11-24 6:52 ` Cyrill Gorcunov
2020-11-24 21:41 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64dc89a9-22bc-56d9-2e4c-4cfd5a508b27@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 00/11] qsync: code refactoring' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox