From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 88006469710 for ; Sat, 21 Nov 2020 02:54:56 +0300 (MSK) References: <20201112195121.191366-1-gorcunov@gmail.com> From: Vladislav Shpilevoy Message-ID: <64dc89a9-22bc-56d9-2e4c-4cfd5a508b27@tarantool.org> Date: Sat, 21 Nov 2020 00:54:54 +0100 MIME-Version: 1.0 In-Reply-To: <20201112195121.191366-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 00/11] qsync: code refactoring List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Hi! Thanks for the patchset! I won't explain again (third or forth time, I don't remember), why we don't do refactoring for the sake of refactoring. You can find it in the mailing list and re-read, if you want. Sorry if sounds rude, but I give up after explaining it so many times. So I will simply write NACK for the commits, which literally don't do anything except subjectively 'more readable' changes. If you disagree, respond to my emails why concretely. It means you can prove that the commit fixes a bug, or fixes some serious flaw in the code style which makes the code look corrupted and totally unreadable with wrong variable names etc, or it reduces some huge code duplication. Other things are subjective. Commits 2, 3, 5, 11 LGTM. I will commit them when the rest of the patches are reviewed, discussed, and everyone agrees with the decisions.