Re: [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

In proposed patch series set_target_properties() uses certain target 
name instead of variable.

Fixed with patch below and force-pushed to the branch:

--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -328,7 +328,7 @@ endif()
  set(LIBLUAJIT_DEPS ${LIBLUAJIT_STATIC_DEPS} ${LIBLUAJIT_SHARED_DEPS})

  add_executable(${LUAJIT_BIN} EXCLUDE_FROM_ALL ${CLI_SOURCES})
-set_target_properties(luajit_shared PROPERTIES
+set_target_properties(${LUAJIT_BIN} PROPERTIES
    OUTPUT_NAME "${LUAJIT_CLI_NAME}"
    COMPILE_FLAGS "${TARGET_C_FLAGS}"
    LINK_FLAGS "${TARGET_BIN_FLAGS}"

Sergey


On 02.06.2022 16:22, Sergey Bronnikov wrote:
> Patch series support of Ninja to a LuaJIT build system and a new job to
> continuous integration pipeline that builds using Ninja.
>
> On my laptop Ninja reduces building time by 14% (with Make it takes 5.7
> sec, with Ninja 3.9 sec). It is not so much, but without Ninja support
> in LuaJIT it is not possible to build Tarantool with Ninja.
>
> Branch: https://github.com/tarantool/luajit/tree/ligurio/ninja-support
> CI status: https://github.com/tarantool/luajit/commit/acfd7552f1b8428242a6b8cbc783ed584c21beef
>
> Sergey Bronnikov (5):
>    build/ninja: refactoring
>    build/ninja: create target with cli binary only once
>    build/ninja: rename default target
>    build/ninja: create file lists outside of cmake commands
>    ci: add job with build using Ninja on linux-x86_64
>
>   .github/workflows/linux-x86_64-ninja.yml | 51 ++++++++++++++++++++++++
>   src/CMakeLists.txt                       | 46 ++++++++-------------
>   src/host/CMakeLists.txt                  |  6 ++-
>   3 files changed, 72 insertions(+), 31 deletions(-)
>   create mode 100644 .github/workflows/linux-x86_64-ninja.yml
>