From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 01C176EFDA; Fri, 3 Jun 2022 16:29:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 01C176EFDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1654262949; bh=Kfn+aeepWp2pzpm6vABAxW5cU6laJFK+YrPw3httguU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=tgcwFlRUUL2gU30j+PKGUZ+fZv33qcoqogjUOAxCW/8Jt6Bj4yJEbwgMjEZTCeYWG DEdTgfuYvmBK80yd3d1Ib1ng+e0eCoV7xPNLZ6XvgZOPxw2J8ogwZQ1GY8/aSGMN02 999l12pTFbehpxHtFlr+OdYxs6FmwgDGisdRubfg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BC8A56EFDA for ; Fri, 3 Jun 2022 16:29:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC8A56EFDA Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nx7MQ-0003of-UY; Fri, 03 Jun 2022 16:29:07 +0300 Message-ID: <60915040-0510-d369-19f1-5d03e33c6bb6@tarantool.org> Date: Fri, 3 Jun 2022 16:29:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-4EC0790: 1 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9B6FDF9E42666DA2B558C4D907976F253F505A04F9C16CE33182A05F5380850404C228DA9ACA6FE270318E61030D451E75528E32F60F261335C480799D010E9DA735A777D96314C6A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70D278D70F8433719EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DDCE02C19EA0BA868638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A19FE60FDA01AC2783CF09222847627B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6ACE00135B021D8CA089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5562C11A403D591C4B0EA1ABDCDB410FBA988F08740C53B5BD59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC223B6CC5B2DFACC29F5D515BBEC05660A3A03CC798CD986F7D809049664FE677BE7A3B815195881D7E09C32AA3244C717F7CD4163AAE05143072D488365DE59CA7333006C390A0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZQX5hKFvZ7FAAfwBCKgvZQ== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D678E8A551566D7AC33A8E44E58414069DDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" In proposed patch series set_target_properties() uses certain target name instead of variable. Fixed with patch below and force-pushed to the branch: --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -328,7 +328,7 @@ endif()  set(LIBLUAJIT_DEPS ${LIBLUAJIT_STATIC_DEPS} ${LIBLUAJIT_SHARED_DEPS})  add_executable(${LUAJIT_BIN} EXCLUDE_FROM_ALL ${CLI_SOURCES}) -set_target_properties(luajit_shared PROPERTIES +set_target_properties(${LUAJIT_BIN} PROPERTIES    OUTPUT_NAME "${LUAJIT_CLI_NAME}"    COMPILE_FLAGS "${TARGET_C_FLAGS}"    LINK_FLAGS "${TARGET_BIN_FLAGS}" Sergey On 02.06.2022 16:22, Sergey Bronnikov wrote: > Patch series support of Ninja to a LuaJIT build system and a new job to > continuous integration pipeline that builds using Ninja. > > On my laptop Ninja reduces building time by 14% (with Make it takes 5.7 > sec, with Ninja 3.9 sec). It is not so much, but without Ninja support > in LuaJIT it is not possible to build Tarantool with Ninja. > > Branch: https://github.com/tarantool/luajit/tree/ligurio/ninja-support > CI status: https://github.com/tarantool/luajit/commit/acfd7552f1b8428242a6b8cbc783ed584c21beef > > Sergey Bronnikov (5): > build/ninja: refactoring > build/ninja: create target with cli binary only once > build/ninja: rename default target > build/ninja: create file lists outside of cmake commands > ci: add job with build using Ninja on linux-x86_64 > > .github/workflows/linux-x86_64-ninja.yml | 51 ++++++++++++++++++++++++ > src/CMakeLists.txt | 46 ++++++++------------- > src/host/CMakeLists.txt | 6 ++- > 3 files changed, 72 insertions(+), 31 deletions(-) > create mode 100644 .github/workflows/linux-x86_64-ninja.yml >