From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja
Date: Mon, 20 Jun 2022 15:48:13 +0300 [thread overview]
Message-ID: <YrBsjb+fEMPa0Tkf@tarantool.org> (raw)
In-Reply-To: <cover.1654175362.git.sergeyb@tarantool.org>
Sergey,
I've checked the patch into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.
On 02.06.22, Sergey Bronnikov wrote:
> Patch series support of Ninja to a LuaJIT build system and a new job to
> continuous integration pipeline that builds using Ninja.
>
> On my laptop Ninja reduces building time by 14% (with Make it takes 5.7
> sec, with Ninja 3.9 sec). It is not so much, but without Ninja support
> in LuaJIT it is not possible to build Tarantool with Ninja.
>
> Branch: https://github.com/tarantool/luajit/tree/ligurio/ninja-support
> CI status: https://github.com/tarantool/luajit/commit/acfd7552f1b8428242a6b8cbc783ed584c21beef
>
> Sergey Bronnikov (5):
> build/ninja: refactoring
> build/ninja: create target with cli binary only once
> build/ninja: rename default target
> build/ninja: create file lists outside of cmake commands
> ci: add job with build using Ninja on linux-x86_64
>
> .github/workflows/linux-x86_64-ninja.yml | 51 ++++++++++++++++++++++++
> src/CMakeLists.txt | 46 ++++++++-------------
> src/host/CMakeLists.txt | 6 ++-
> 3 files changed, 72 insertions(+), 31 deletions(-)
> create mode 100644 .github/workflows/linux-x86_64-ninja.yml
>
> --
> 2.25.1
>
--
Best regards,
IM
next prev parent reply other threads:[~2022-06-20 12:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 13:22 Sergey Bronnikov via Tarantool-patches
2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 1/5] build/ninja: refactoring Sergey Bronnikov via Tarantool-patches
2022-06-15 8:56 ` Sergey Kaplun via Tarantool-patches
2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 2/5] build/ninja: create target with cli binary only once Sergey Bronnikov via Tarantool-patches
2022-06-15 9:10 ` Sergey Kaplun via Tarantool-patches
2022-06-15 16:03 ` Sergey Bronnikov via Tarantool-patches
2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 3/5] build/ninja: rename default target Sergey Bronnikov via Tarantool-patches
2022-06-15 9:11 ` Sergey Kaplun via Tarantool-patches
2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 4/5] build/ninja: create file lists outside of cmake commands Sergey Bronnikov via Tarantool-patches
2022-06-15 8:48 ` Igor Munkin via Tarantool-patches
2022-06-15 9:19 ` Sergey Kaplun via Tarantool-patches
2022-06-15 14:31 ` Sergey Bronnikov via Tarantool-patches
2022-06-03 13:29 ` [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja Sergey Bronnikov via Tarantool-patches
2022-06-06 11:24 ` [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64 Sergey Bronnikov via Tarantool-patches
2022-06-15 8:48 ` Igor Munkin via Tarantool-patches
2022-06-15 9:27 ` Sergey Kaplun via Tarantool-patches
2022-06-15 14:09 ` Sergey Bronnikov via Tarantool-patches
2022-06-15 14:15 ` Sergey Bronnikov via Tarantool-patches
2022-06-15 8:47 ` [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja Igor Munkin via Tarantool-patches
2022-06-15 14:57 ` Sergey Bronnikov via Tarantool-patches
2022-06-20 12:48 ` Igor Munkin via Tarantool-patches [this message]
2022-06-20 13:04 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrBsjb+fEMPa0Tkf@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=imun@tarantool.org \
--subject='Re: [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox