From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64 Date: Wed, 15 Jun 2022 17:15:09 +0300 [thread overview] Message-ID: <1e782540-e304-7432-b279-eb33d5f38ca3@tarantool.org> (raw) In-Reply-To: <Yqmc50zsDBZuhwck@tarantool.org> Igor, thanks for review! On 15.06.2022 11:48, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM as trivial, but please consider nits below. > > On 06.06.22, Sergey Bronnikov wrote: <snipped> >> + >> +jobs: >> + test-linux-x86_64: >> + runs-on: ubuntu-20.04-self-hosted >> + strategy: >> + fail-fast: false >> + name: Linux/x86_64 ${{ matrix.BUILDTYPE }} > There is no testing matrix, so you can just name the workflow kinda > "Linux/x86_64 Ninja". Renamed to "Linux/x86_64 Ninja". >> + steps: >> + - uses: actions/checkout@v2.3.4 >> + with: >> + fetch-depth: 0 >> + submodules: recursive >> + - name: setup >> + run: | >> + sudo apt -y update >> + sudo apt -y install cmake ninja-build gcc perl >> + - name: configure >> + run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja >> + - name: build >> + run: cmake --build . -j $(nproc) >> + - name: test >> + run: cmake --build . -j $(nproc) -t test > Please, use long options, as we discussed here[1]. Fixed: --- a/.github/workflows/linux-x86_64-ninja.yml +++ b/.github/workflows/linux-x86_64-ninja.yml @@ -44,6 +44,6 @@ jobs: - name: configure run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja - name: build - run: cmake --build . -j $(nproc) + run: cmake --build . --parallel $(($(nproc) + 1)) - name: test - run: cmake --build . -j $(nproc) -t test + run: cmake --build . --parallel $(($(nproc) + 1)) --target test > >> -- >> 2.25.1 >> > [1]: https://lists.tarantool.org/tarantool-patches/YpjeijSClWO0v82Y@tarantool.org/ >
next prev parent reply other threads:[~2022-06-15 14:15 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-02 13:22 [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja Sergey Bronnikov via Tarantool-patches 2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 1/5] build/ninja: refactoring Sergey Bronnikov via Tarantool-patches 2022-06-15 8:56 ` Sergey Kaplun via Tarantool-patches 2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 2/5] build/ninja: create target with cli binary only once Sergey Bronnikov via Tarantool-patches 2022-06-15 9:10 ` Sergey Kaplun via Tarantool-patches 2022-06-15 16:03 ` Sergey Bronnikov via Tarantool-patches 2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 3/5] build/ninja: rename default target Sergey Bronnikov via Tarantool-patches 2022-06-15 9:11 ` Sergey Kaplun via Tarantool-patches 2022-06-02 13:22 ` [Tarantool-patches] [v2][PATCH 4/5] build/ninja: create file lists outside of cmake commands Sergey Bronnikov via Tarantool-patches 2022-06-15 8:48 ` Igor Munkin via Tarantool-patches 2022-06-15 9:19 ` Sergey Kaplun via Tarantool-patches 2022-06-15 14:31 ` Sergey Bronnikov via Tarantool-patches 2022-06-03 13:29 ` [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja Sergey Bronnikov via Tarantool-patches 2022-06-06 11:24 ` [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64 Sergey Bronnikov via Tarantool-patches 2022-06-15 8:48 ` Igor Munkin via Tarantool-patches 2022-06-15 9:27 ` Sergey Kaplun via Tarantool-patches 2022-06-15 14:09 ` Sergey Bronnikov via Tarantool-patches 2022-06-15 14:15 ` Sergey Bronnikov via Tarantool-patches [this message] 2022-06-15 8:47 ` [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja Igor Munkin via Tarantool-patches 2022-06-15 14:57 ` Sergey Bronnikov via Tarantool-patches 2022-06-20 12:48 ` Igor Munkin via Tarantool-patches 2022-06-20 13:04 ` Sergey Bronnikov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1e782540-e304-7432-b279-eb33d5f38ca3@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox