From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1977D6ECE3; Wed, 15 Jun 2022 17:15:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1977D6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655302512; bh=kC3DZaxpws0XAGejJs5/C9g3GR2rkmow8b+ouHmX3Rc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=pqBllDngeKLOlOEAkvTMdiQ2kLapaW7Vp4/VD+eRRLKfPD70TmWVCJxjawUVIXjVy yAhx8ZZfauQjewKutYlZYXbEO9buQ3N1i8ULgJUcxVYch3qtih7nevRXfk3tRB679/ /23JIR/cAudi0cUU6Kbsl8wCD0WiC/1RVpVYzCyQ= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6BDB26ECE3 for ; Wed, 15 Jun 2022 17:15:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6BDB26ECE3 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1o1TnZ-0004Nb-Sh; Wed, 15 Jun 2022 17:15:10 +0300 Message-ID: <1e782540-e304-7432-b279-eb33d5f38ca3@tarantool.org> Date: Wed, 15 Jun 2022 17:15:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97D44297578DBEB86157A728CB9AF912FB29B9D39C83553BE182A05F53808504026A7200D64330209BC198AC603C24EC6D7F066D62CA087A85895D9B211DB9B17 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6702EC5472AA0FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379347C0682FC030B08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86E7A4958A236960E42D7598794FBBFFA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B043FB282AF95FB6BD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3724336BCC0EE1BA8AD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377F02F59195295693EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C529435B181E89340ACDCBC367D5D833C7F03A1B7A1CB6320AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3458239C6F30CE7ACFB2BACDE1BF5D2D46312227FF64919D33629E26FDD1ED00E9585DFA30A33B8AA61D7E09C32AA3244CFAB91D3AF52E04E90D0AD16F5F273D7CC86C126E7119A0FE729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCCvLuneITNon5DCFSP6/1Q== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845879919CBA8661A437A2060EBB4CD9C837B5833D13168EBA11282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, thanks for review! On 15.06.2022 11:48, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM as trivial, but please consider nits below. > > On 06.06.22, Sergey Bronnikov wrote: >> + >> +jobs: >> + test-linux-x86_64: >> + runs-on: ubuntu-20.04-self-hosted >> + strategy: >> + fail-fast: false >> + name: Linux/x86_64 ${{ matrix.BUILDTYPE }} > There is no testing matrix, so you can just name the workflow kinda > "Linux/x86_64 Ninja". Renamed to "Linux/x86_64 Ninja". >> + steps: >> + - uses: actions/checkout@v2.3.4 >> + with: >> + fetch-depth: 0 >> + submodules: recursive >> + - name: setup >> + run: | >> + sudo apt -y update >> + sudo apt -y install cmake ninja-build gcc perl >> + - name: configure >> + run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja >> + - name: build >> + run: cmake --build . -j $(nproc) >> + - name: test >> + run: cmake --build . -j $(nproc) -t test > Please, use long options, as we discussed here[1]. Fixed: --- a/.github/workflows/linux-x86_64-ninja.yml +++ b/.github/workflows/linux-x86_64-ninja.yml @@ -44,6 +44,6 @@ jobs:        - name: configure          run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja        - name: build -        run: cmake --build . -j $(nproc) +        run: cmake --build . --parallel $(($(nproc) + 1))        - name: test -        run: cmake --build . -j $(nproc) -t test +        run: cmake --build . --parallel $(($(nproc) + 1)) --target test > >> -- >> 2.25.1 >> > [1]: https://lists.tarantool.org/tarantool-patches/YpjeijSClWO0v82Y@tarantool.org/ >