From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 3/4] raft: add explicit raft argument to all functions
Date: Tue, 10 Nov 2020 01:00:13 +0100 [thread overview]
Message-ID: <4905fbad-b191-06c3-dbd4-853353b763bf@tarantool.org> (raw)
In-Reply-To: <62d3f8fa-20ae-477d-f73c-9aab04d43035@tarantool.org>
Thanks for the review!
>> @@ -535,7 +538,6 @@ raft_write_cb(struct journal_entry *entry)
>> static void
>> raft_write_request(const struct raft_request *req)
>> {
>> - assert(raft.is_write_in_progress);
> Not related to this patch, just a thought.
> Looks like raft_write_request belongs to some other file now.
> Will you move it somewhere else?
> I don't know where to put it though. box.cc?
Yes, this is what I am going to do in the end. When I will move
raft to src/lib/raft, some box-specific functions will stay in
src/box.
The raft library will use them as virtual functions.
I will unbind raft from box in Part 2 of my work on this issue.
next prev parent reply other threads:[~2020-11-10 0:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 18:03 [Tarantool-patches] [PATCH 0/4] Raft module, part 1 - explicit argument Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 1/4] fiber: introduce fiber.arg Vladislav Shpilevoy
2020-11-09 12:49 ` Serge Petrenko
2020-11-09 14:27 ` Cyrill Gorcunov
2020-11-09 23:59 ` Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 2/4] raft: initialize raft completely at runtime Vladislav Shpilevoy
2020-11-09 12:50 ` Serge Petrenko
2020-11-09 14:59 ` Cyrill Gorcunov
2020-11-09 23:59 ` Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 3/4] raft: add explicit raft argument to all functions Vladislav Shpilevoy
2020-11-09 13:46 ` Serge Petrenko
2020-11-10 0:00 ` Vladislav Shpilevoy [this message]
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 4/4] vclock: move to src/lib Vladislav Shpilevoy
2020-11-09 14:12 ` Serge Petrenko
2020-11-09 15:01 ` Cyrill Gorcunov
2020-11-10 21:06 ` [Tarantool-patches] [PATCH 0/4] Raft module, part 1 - explicit argument Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4905fbad-b191-06c3-dbd4-853353b763bf@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/4] raft: add explicit raft argument to all functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox