From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F3D3C469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Nov 2020 03:00:14 +0300 (MSK)
References: <cover.1604858551.git.v.shpilevoy@tarantool.org>
 <cdf127ac4f9cfb6428cb15c588442054e7895626.1604858551.git.v.shpilevoy@tarantool.org>
 <62d3f8fa-20ae-477d-f73c-9aab04d43035@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <4905fbad-b191-06c3-dbd4-853353b763bf@tarantool.org>
Date: Tue, 10 Nov 2020 01:00:13 +0100
MIME-Version: 1.0
In-Reply-To: <62d3f8fa-20ae-477d-f73c-9aab04d43035@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 3/4] raft: add explicit raft
	argument to all functions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, tarantool-patches@dev.tarantool.org, gorcunov@gmail.com

Thanks for the review!

>> @@ -535,7 +538,6 @@ raft_write_cb(struct journal_entry *entry)
>>   static void
>>   raft_write_request(const struct raft_request *req)
>>   {
>> -    assert(raft.is_write_in_progress);
> Not related to this patch, just a thought.
> Looks like raft_write_request belongs to some other file now.
> Will you move it somewhere else?
> I don't know where to put it though. box.cc?

Yes, this is what I am going to do in the end. When I will move
raft to src/lib/raft, some box-specific functions will stay in
src/box.

The raft library will use them as virtual functions.

I will unbind raft from box in Part 2 of my work on this issue.