Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/4] Raft module, part 1 - explicit argument
Date: Wed, 11 Nov 2020 00:06:19 +0300	[thread overview]
Message-ID: <20201110210619.GB25467@hpalx> (raw)
In-Reply-To: <cover.1604858551.git.v.shpilevoy@tarantool.org>

Hi Vlad, I've checked all results in gitlab-ci, and no new degradations
found [1], patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/213931911

On Sun, Nov 08, 2020 at 07:03:53PM +0100, Vladislav Shpilevoy wrote:
> The patchset is a first part of Raft movement to a separate library as
> src/lib/raft.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5303-p1-raft-explicit-arg
> Issue: https://github.com/tarantool/tarantool/issues/5303
> 
> Vladislav Shpilevoy (4):
>   fiber: introduce fiber.arg
>   raft: initialize raft completely at runtime
>   raft: add explicit raft argument to all functions
>   vclock: move to src/lib
> 
>  src/box/CMakeLists.txt           |   3 -
>  src/box/alter.cc                 |   1 -
>  src/box/applier.cc               |   6 +-
>  src/box/box.cc                   |  27 +-
>  src/box/error.cc                 |   2 +-
>  src/box/gc.c                     |   1 -
>  src/box/gc.h                     |   2 +-
>  src/box/lua/info.c               |   8 +-
>  src/box/lua/init.c               |   1 -
>  src/box/lua/space.cc             |   2 +-
>  src/box/memtx_engine.c           |   4 +-
>  src/box/raft.c                   | 638 +++++++++++++++++--------------
>  src/box/raft.h                   |  72 ++--
>  src/box/recovery.h               |   2 +-
>  src/box/relay.cc                 |   2 +-
>  src/box/replication.cc           |   1 -
>  src/box/replication.h            |   2 +-
>  src/box/schema.cc                |   2 +-
>  src/box/txn_limbo.h              |   2 +-
>  src/box/vy_log.c                 |   2 +-
>  src/box/wal.c                    |   1 -
>  src/box/wal.h                    |   2 +-
>  src/box/xlog.h                   |   2 +-
>  src/box/xrow.c                   |   1 -
>  src/box/xrow.h                   |   2 +-
>  src/lib/CMakeLists.txt           |   1 +
>  src/lib/core/fiber.h             |  14 +-
>  src/lib/vclock/CMakeLists.txt    |   6 +
>  src/{box => lib/vclock}/vclock.c |   0
>  src/{box => lib/vclock}/vclock.h |   0
>  test/unit/vclock.cc              |   2 +-
>  31 files changed, 444 insertions(+), 367 deletions(-)
>  create mode 100644 src/lib/vclock/CMakeLists.txt
>  rename src/{box => lib/vclock}/vclock.c (100%)
>  rename src/{box => lib/vclock}/vclock.h (100%)
> 
> -- 
> 2.21.1 (Apple Git-122.3)
> 

      parent reply	other threads:[~2020-11-10 21:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 18:03 Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 1/4] fiber: introduce fiber.arg Vladislav Shpilevoy
2020-11-09 12:49   ` Serge Petrenko
2020-11-09 14:27   ` Cyrill Gorcunov
2020-11-09 23:59     ` Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 2/4] raft: initialize raft completely at runtime Vladislav Shpilevoy
2020-11-09 12:50   ` Serge Petrenko
2020-11-09 14:59   ` Cyrill Gorcunov
2020-11-09 23:59     ` Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 3/4] raft: add explicit raft argument to all functions Vladislav Shpilevoy
2020-11-09 13:46   ` Serge Petrenko
2020-11-10  0:00     ` Vladislav Shpilevoy
2020-11-08 18:03 ` [Tarantool-patches] [PATCH 4/4] vclock: move to src/lib Vladislav Shpilevoy
2020-11-09 14:12   ` Serge Petrenko
2020-11-09 15:01   ` Cyrill Gorcunov
2020-11-10 21:06 ` Alexander V. Tikhonov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110210619.GB25467@hpalx \
    --to=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/4] Raft module, part 1 - explicit argument' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox