From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DC9AE469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 11 Nov 2020 00:06:21 +0300 (MSK)
Date: Wed, 11 Nov 2020 00:06:19 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201110210619.GB25467@hpalx>
References: <cover.1604858551.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1604858551.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/4] Raft module,
 part 1 - explicit argument
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Vlad, I've checked all results in gitlab-ci, and no new degradations
found [1], patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/213931911

On Sun, Nov 08, 2020 at 07:03:53PM +0100, Vladislav Shpilevoy wrote:
> The patchset is a first part of Raft movement to a separate library as
> src/lib/raft.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5303-p1-raft-explicit-arg
> Issue: https://github.com/tarantool/tarantool/issues/5303
> 
> Vladislav Shpilevoy (4):
>   fiber: introduce fiber.arg
>   raft: initialize raft completely at runtime
>   raft: add explicit raft argument to all functions
>   vclock: move to src/lib
> 
>  src/box/CMakeLists.txt           |   3 -
>  src/box/alter.cc                 |   1 -
>  src/box/applier.cc               |   6 +-
>  src/box/box.cc                   |  27 +-
>  src/box/error.cc                 |   2 +-
>  src/box/gc.c                     |   1 -
>  src/box/gc.h                     |   2 +-
>  src/box/lua/info.c               |   8 +-
>  src/box/lua/init.c               |   1 -
>  src/box/lua/space.cc             |   2 +-
>  src/box/memtx_engine.c           |   4 +-
>  src/box/raft.c                   | 638 +++++++++++++++++--------------
>  src/box/raft.h                   |  72 ++--
>  src/box/recovery.h               |   2 +-
>  src/box/relay.cc                 |   2 +-
>  src/box/replication.cc           |   1 -
>  src/box/replication.h            |   2 +-
>  src/box/schema.cc                |   2 +-
>  src/box/txn_limbo.h              |   2 +-
>  src/box/vy_log.c                 |   2 +-
>  src/box/wal.c                    |   1 -
>  src/box/wal.h                    |   2 +-
>  src/box/xlog.h                   |   2 +-
>  src/box/xrow.c                   |   1 -
>  src/box/xrow.h                   |   2 +-
>  src/lib/CMakeLists.txt           |   1 +
>  src/lib/core/fiber.h             |  14 +-
>  src/lib/vclock/CMakeLists.txt    |   6 +
>  src/{box => lib/vclock}/vclock.c |   0
>  src/{box => lib/vclock}/vclock.h |   0
>  test/unit/vclock.cc              |   2 +-
>  31 files changed, 444 insertions(+), 367 deletions(-)
>  create mode 100644 src/lib/vclock/CMakeLists.txt
>  rename src/{box => lib/vclock}/vclock.c (100%)
>  rename src/{box => lib/vclock}/vclock.h (100%)
> 
> -- 
> 2.21.1 (Apple Git-122.3)
>