From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladimir Davydov <vdavydov@tarantool.org>,
Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime
Date: Tue, 24 Aug 2021 23:13:39 +0200 [thread overview]
Message-ID: <4141772d-335c-6f1e-9be6-8e0170d394a2@tarantool.org> (raw)
In-Reply-To: <20210819152656.viku6crt3uezsrdd@esperanza>
>> +local function datetime_tostring(o)
>> + if ffi.typeof(o) == datetime_t then
>> + local sz = 48
>> + local buff = ffi.new('char[?]', sz)
>
> I think we've agreed that the buffer used for formatting should be
> global.
If you are going with a global buffer, please, take into
account Lua GC and tickets 5632, 6050, 6259. If there is
going to be a global buffer, it must be properly shared. For
example, using buffer.ffi_stash_new(). See it source and
usages to find what that is.
next prev parent reply other threads:[~2021-08-24 21:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 2:56 [Tarantool-patches] [PATCH v6 0/5] Initial datetime implementation Timur Safin via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime Timur Safin via Tarantool-patches
2021-08-19 9:43 ` Serge Petrenko via Tarantool-patches
2021-08-19 9:47 ` Safin Timur via Tarantool-patches
2021-08-19 15:26 ` Vladimir Davydov via Tarantool-patches
2021-08-24 21:13 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 2/5] box, datetime: messagepack support for datetime Timur Safin via Tarantool-patches
2021-08-19 9:58 ` Serge Petrenko via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 3/5] box, datetime: datetime comparison for indices Timur Safin via Tarantool-patches
2021-08-19 10:16 ` Serge Petrenko via Tarantool-patches
2021-08-19 11:18 ` UNera via Tarantool-patches
2021-08-19 11:53 ` Safin Timur via Tarantool-patches
2021-08-19 14:47 ` Dmitry E. Oboukhov via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 4/5] datetime: perf test for datetime parser Timur Safin via Tarantool-patches
2021-08-19 10:19 ` Serge Petrenko via Tarantool-patches
2021-08-19 10:29 ` Safin Timur via Tarantool-patches
2021-08-19 11:11 ` Serge Petrenko via Tarantool-patches
2021-08-19 15:58 ` Vladimir Davydov via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 5/5] datetime: changelog for datetime module Timur Safin via Tarantool-patches
2021-08-19 10:20 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4141772d-335c-6f1e-9be6-8e0170d394a2@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox