From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Timur Safin <tsafin@tarantool.org>, vdavydov@tarantool.org, tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime Date: Thu, 19 Aug 2021 12:43:15 +0300 [thread overview] Message-ID: <9ad0ba43-7728-2b8a-005c-8e50af4d3b29@tarantool.org> (raw) In-Reply-To: <dd59371cb49eab89cf229a8c0b6cbbeb002de920.1629341071.git.tsafin@tarantool.org> 19.08.2021 05:56, Timur Safin пишет: ... > diff --git a/src/lib/core/datetime.h b/src/lib/core/datetime.h > new file mode 100644 > index 000000000..71feefded > --- /dev/null > +++ b/src/lib/core/datetime.h > @@ -0,0 +1,86 @@ > +#pragma once > +/* > + * SPDX-License-Identifier: BSD-2-Clause > + * > + * Copyright 2021, Tarantool AUTHORS, please see AUTHORS file. > + */ > + > +#include <stdint.h> > +#include <stdbool.h> > +#include "c-dt/dt.h" > + > +#if defined(__cplusplus) > +extern "C" > +{ > +#endif /* defined(__cplusplus) */ > + > +/** > + * We count dates since so called "Rata Die" date > + * January 1, 0001, Monday (as Day 1). > + * But datetime structure keeps seconds since > + * Unix "Epoch" date: > + * Unix, January 1, 1970, Thursday > + * > + * The difference between Epoch (1970-01-01) > + * and Rata Die (0001-01-01) is 719163 days. > + */ > + > +#ifndef SECS_PER_DAY > +#define SECS_PER_DAY 86400 > +#define DT_EPOCH_1970_OFFSET 719163 > +#endif > + > +#define SECS_EPOCH_1970_OFFSET \ > + ((int64_t)DT_EPOCH_1970_OFFSET * SECS_PER_DAY) > +/** > + * datetime structure keeps number of seconds since > + * Unix Epoch. > + * Time is normalized by UTC, so time-zone offset > + * is informative only. > + */ > +struct datetime { > + /** Seconds since Epoch. */ > + double secs; > + /** Nanoseconds, if any. */ > + uint32_t nsec; > + /** Offset in minutes from UTC. */ > + int32_t offset; > +}; > + > +/** > + * Date/time interval structure > + */ > +struct datetime_interval { > + /** Relative seconds delta. */ > + double secs; > + /** Nanoseconds delta, if any. */ > + uint32_t nsec; > +}; > + Hi! Thanks for working on this! I don't see you use this struct anywhere in the patch. AFAICS interval operations are implemented via add_years(), add_months() and so on. Let's drop the struct then. We may introduce it once it becomes necessary again. Let's also drop the CTID_INTERVAL definition in lua/utils.c LGTM, once you remove the interval. > +/** > + * Convert datetime to string using default format > + * @param date source datetime value > + * @param buf output character buffer > + * @param len size ofoutput buffer > + */ > +int > +datetime_to_string(const struct datetime *date, char *buf, int len); > ... -- Serge Petrenko
next prev parent reply other threads:[~2021-08-19 9:43 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-19 2:56 [Tarantool-patches] [PATCH v6 0/5] Initial datetime implementation Timur Safin via Tarantool-patches 2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime Timur Safin via Tarantool-patches 2021-08-19 9:43 ` Serge Petrenko via Tarantool-patches [this message] 2021-08-19 9:47 ` Safin Timur via Tarantool-patches 2021-08-19 15:26 ` Vladimir Davydov via Tarantool-patches 2021-08-24 21:13 ` Vladislav Shpilevoy via Tarantool-patches 2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 2/5] box, datetime: messagepack support for datetime Timur Safin via Tarantool-patches 2021-08-19 9:58 ` Serge Petrenko via Tarantool-patches 2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 3/5] box, datetime: datetime comparison for indices Timur Safin via Tarantool-patches 2021-08-19 10:16 ` Serge Petrenko via Tarantool-patches 2021-08-19 11:18 ` UNera via Tarantool-patches 2021-08-19 11:53 ` Safin Timur via Tarantool-patches 2021-08-19 14:47 ` Dmitry E. Oboukhov via Tarantool-patches 2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 4/5] datetime: perf test for datetime parser Timur Safin via Tarantool-patches 2021-08-19 10:19 ` Serge Petrenko via Tarantool-patches 2021-08-19 10:29 ` Safin Timur via Tarantool-patches 2021-08-19 11:11 ` Serge Petrenko via Tarantool-patches 2021-08-19 15:58 ` Vladimir Davydov via Tarantool-patches 2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 5/5] datetime: changelog for datetime module Timur Safin via Tarantool-patches 2021-08-19 10:20 ` Serge Petrenko via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9ad0ba43-7728-2b8a-005c-8e50af4d3b29@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=tsafin@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --cc=vdavydov@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox