From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Timur Safin <tsafin@tarantool.org>,
vdavydov@tarantool.org, tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v6 2/5] box, datetime: messagepack support for datetime
Date: Thu, 19 Aug 2021 12:58:29 +0300 [thread overview]
Message-ID: <313f37b8-8305-f713-e28b-ed8f29c06228@tarantool.org> (raw)
In-Reply-To: <003a95dc7856f488a551eacb66b0920629a62ab7.1629341071.git.tsafin@tarantool.org>
19.08.2021 05:56, Timur Safin пишет:
> Serialize `struct datetime` as newly introduced MP_EXT type.
> It saves 1 required integer field and upto 2 optional
> unsigned fields in very compact fashion.
> - secs is required field;
> - but nsec, offset are both optional;
>
> * json, yaml serialization formats, lua output mode
> supported;
> * exported symbols for datetime messagepack size calculations
> so they are available for usage on Lua side.
>
> * As a bonus we introduce core/mp_utils.h with set of helpers
> which simplify working with mp_sizeof*/mp_encode_*/mp_decode_*
> functions regardless of a signedness of an integer data we
> deal with.
>
> Part of #5941
> Part of #5946
Thanks! LGTM.
--
Serge Petrenko
next prev parent reply other threads:[~2021-08-19 9:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 2:56 [Tarantool-patches] [PATCH v6 0/5] Initial datetime implementation Timur Safin via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime Timur Safin via Tarantool-patches
2021-08-19 9:43 ` Serge Petrenko via Tarantool-patches
2021-08-19 9:47 ` Safin Timur via Tarantool-patches
2021-08-19 15:26 ` Vladimir Davydov via Tarantool-patches
2021-08-24 21:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 2/5] box, datetime: messagepack support for datetime Timur Safin via Tarantool-patches
2021-08-19 9:58 ` Serge Petrenko via Tarantool-patches [this message]
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 3/5] box, datetime: datetime comparison for indices Timur Safin via Tarantool-patches
2021-08-19 10:16 ` Serge Petrenko via Tarantool-patches
2021-08-19 11:18 ` UNera via Tarantool-patches
2021-08-19 11:53 ` Safin Timur via Tarantool-patches
2021-08-19 14:47 ` Dmitry E. Oboukhov via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 4/5] datetime: perf test for datetime parser Timur Safin via Tarantool-patches
2021-08-19 10:19 ` Serge Petrenko via Tarantool-patches
2021-08-19 10:29 ` Safin Timur via Tarantool-patches
2021-08-19 11:11 ` Serge Petrenko via Tarantool-patches
2021-08-19 15:58 ` Vladimir Davydov via Tarantool-patches
2021-08-19 2:56 ` [Tarantool-patches] [PATCH v6 5/5] datetime: changelog for datetime module Timur Safin via Tarantool-patches
2021-08-19 10:20 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313f37b8-8305-f713-e28b-ed8f29c06228@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 2/5] box, datetime: messagepack support for datetime' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox