Re: [Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

Hi, Evgeniy,

thanks for the patch! LGTM with minor comments.

Sergey

On 8/8/26 02:00, Evgeniy Temirgaleev wrote:
> From: Temir Galeev<temir.galeev@bk.ru>
>
> The brew gcc installation is useless, because cmake use
> the clang compiler which is already present in the system.
>
> Also, the clang is better than gcc for macOS.
>
> Branch:https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac
>
> ---
>   .github/actions/setup-macos/action.yml | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
> index 91632648..9e752a70 100644
> --- a/.github/actions/setup-macos/action.yml
> +++ b/.github/actions/setup-macos/action.yml
> @@ -32,6 +32,9 @@ runs:
>           # Try to install the packages either upgrade it to avoid
>           # of fails if the package already exists with the previous
>           # version.
> -        brew install --force cmake gcc make ninja perl ||
> -          brew upgrade cmake gcc make ninja perl
> +        # We skip gcc installation because the 'builtin' clang compiler

We usually write comments in a depersonalized manner and names in uppercase:

> Skip GCC installation because the 'builtin' clang compiler
 > is already present in the system. It is used by CMake
 > by default even if GCC is installed.

> +        # is already present in the system. It is used by cmake
> +        # by default even if gcc is installed.
> +        brew install --force cmake make ninja perl ||
> +          brew upgrade cmake make ninja perl
>         shell: bash

[-- Attachment #2: Type: text/html, Size: 2585 bytes --]