From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3FD626ECCC; Thu, 27 Aug 2026 12:35:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3FD626ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1787823310; bh=jVh29c/fpf9/uNhl1AYsvEXnvsSA0MFPQvIKgVNjyD8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fU/rTNTSQBfNN0gaiTSfIcCft8WMDfuQi7F2swqjcs4H7dDvflkIRkgDSyFxLMSDW w3r/SQaa91ZpHfUIoW7kF09oBdC5vUw4j7LYcT6vXsJKG81NHw/I4h4dqclglwzk9P 4D4wzbmeTW9rJ6CgBqeMQ6QhbYluRjBkFLfQTR/I= Received: from send127.i.mail.ru (send127.i.mail.ru [89.221.237.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 565076ECCC for ; Thu, 27 Aug 2026 12:35:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 565076ECCC Received: by exim-smtp-67896c5f6-j22fh with esmtpa (envelope-from ) id 1wzWVn-00000000O5T-119x; Thu, 27 Aug 2026 12:35:07 +0300 Content-Type: multipart/alternative; boundary="------------K0O04iae1KmsF0nK2Y3N8jS2" Message-ID: <3ea168e6-8841-4e94-aba2-70903a4deb0d@tarantool.org> Date: Thu, 27 Aug 2026 12:35:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Evgeniy Temirgaleev , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20260807230049.13128-1-e.temirgaleev@tarantool.org> Content-Language: en-US In-Reply-To: <20260807230049.13128-1-e.temirgaleev@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92DFEB37D5DA7DF78472818EF5C799B2DDC5D39B8736E9E8900894C459B0CD1B90A19B77FE9AEE9A005B18F8CB88C7B49C1BF06B2C17C13B2CA0E0C07B31FB6E82A808E2AF9A6ECDE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73F64378C139886A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2EFE9AB6201CDA7D22E070BE324C7D3C4B6BCF6707D085408F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D52CD31C43BF465FCC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C06030C3405640F6718941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3D8B0ABA717EF295735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5BD44ECB6D11507135002B1117B3ED6960002C64F2F2DA9804A0A47EBA01A636A823CB91A9FED034534781492E4B8EEADD0953842B444AAC3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6598E74583FAFDFB502BBC9DD7075DDCE16AE6C40B6CBE8C1DC2A59FAFFEBAE8A52B290A0C8DE085884B8341EE9D5BE9A0A63D08BEA32C8BA3E7262949E520ED27C0B151A2FC6455A6E6536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVd9Ysz+d4RqW2l1Amg+w2NE= X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2EAA28A3BAF3F1B100B23C16D1F6F8853571F93CA48FB4FA2EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------K0O04iae1KmsF0nK2Y3N8jS2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Evgeniy, thanks for the patch! LGTM with minor comments. Sergey On 8/8/26 02:00, Evgeniy Temirgaleev wrote: > From: Temir Galeev > > The brew gcc installation is useless, because cmake use > the clang compiler which is already present in the system. > > Also, the clang is better than gcc for macOS. > > Branch:https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac > > --- > .github/actions/setup-macos/action.yml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml > index 91632648..9e752a70 100644 > --- a/.github/actions/setup-macos/action.yml > +++ b/.github/actions/setup-macos/action.yml > @@ -32,6 +32,9 @@ runs: > # Try to install the packages either upgrade it to avoid > # of fails if the package already exists with the previous > # version. > - brew install --force cmake gcc make ninja perl || > - brew upgrade cmake gcc make ninja perl > + # We skip gcc installation because the 'builtin' clang compiler We usually write comments in a depersonalized manner and names in uppercase: > Skip GCC installation because the 'builtin' clang compiler > is already present in the system. It is used by CMake > by default even if GCC is installed. > + # is already present in the system. It is used by cmake > + # by default even if gcc is installed. > + brew install --force cmake make ninja perl || > + brew upgrade cmake make ninja perl > shell: bash --------------K0O04iae1KmsF0nK2Y3N8jS2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Evgeniy,

thanks for the patch! LGTM with minor comments.

Sergey

On 8/8/26 02:00, Evgeniy Temirgaleev wrote:
From: Temir Galeev <temir.galeev@bk.ru>

The brew gcc installation is useless, because cmake use
the clang compiler which is already present in the system.

Also, the clang is better than gcc for macOS.

Branch: https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac

---
 .github/actions/setup-macos/action.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
index 91632648..9e752a70 100644
--- a/.github/actions/setup-macos/action.yml
+++ b/.github/actions/setup-macos/action.yml
@@ -32,6 +32,9 @@ runs:
         # Try to install the packages either upgrade it to avoid
         # of fails if the package already exists with the previous
         # version.
-        brew install --force cmake gcc make ninja perl ||
-          brew upgrade cmake gcc make ninja perl
+        # We skip gcc installation because the 'builtin' clang compiler

We usually write comments in a depersonalized manner and names in uppercase:

> Skip GCC installation because the 'builtin' clang compiler
> is already present in the system. It is used by CMake
> by default even if GCC is installed.

+        # is already present in the system. It is used by cmake
+        # by default even if gcc is installed.
+        brew install --force cmake make ninja perl ||
+          brew upgrade cmake make ninja perl
       shell: bash
--------------K0O04iae1KmsF0nK2Y3N8jS2--