Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup
Date: Mon, 17 Aug 2026 15:32:12 +0300	[thread overview]
Message-ID: <aoL_TKCA1KbIYLsm@root> (raw)
In-Reply-To: <20260807230049.13128-1-e.temirgaleev@tarantool.org>

Hi, Evgeniy!
Thanks for the patch!
LGTM, with minor nits regarding the commit message.

On 08.08.26, Evgeniy Temirgaleev wrote:
> From: Temir Galeev <temir.galeev@bk.ru>
> 
> The brew gcc installation is useless, because cmake use

Typo: s/use/uses/

> the clang compiler which is already present in the system.

Typo: s/compiler/compiler,/

> 
> Also, the clang is better than gcc for macOS.
> 
> Branch: https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac

Side note: It's better to insert the additional info under --- below to
avoid confusion with the commit message.

> 
> ---
>  .github/actions/setup-macos/action.yml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
> index 91632648..9e752a70 100644
> --- a/.github/actions/setup-macos/action.yml
> +++ b/.github/actions/setup-macos/action.yml

<snipped>

> 

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2026-08-17 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 23:00 Evgeniy Temirgaleev via Tarantool-patches
2026-08-17 12:32 ` Sergey Kaplun via Tarantool-patches [this message]
2026-08-18 18:57   ` Evgeniy Temirgaleev via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoL_TKCA1KbIYLsm@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox