Re: [Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup

[Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]

Hi, Sergey!
Thanks for review!
Fixed issues and force pushed the branch.

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
> Cc: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org
> 
> Date: Monday, August 17, 2026 3:32 PM +03:00
> Hi, Evgeniy!
> Thanks for the patch!
> LGTM, with minor nits regarding the commit message.
> 
> On 08.08.26, Evgeniy Temirgaleev wrote:
> > From: Temir Galeev <temir.galeev@bk.ru>
> >
> > The brew gcc installation is useless, because cmake use
> 
> Typo: s/use/uses/
> 

fixed

> 
> 
> > the clang compiler which is already present in the system.
> 
> Typo: s/compiler/compiler,/
> 

fixed

> 
> 
> >
> > Also, the clang is better than gcc for macOS.
> >
> > Branch: https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac
> 
> 
> Side note: It's better to insert the additional info under --- below to
> avoid confusion with the commit message.
> 

Thanks! But here the note about clang is a part of the commit message.

> 
> 
> >
> > ---
> > .github/actions/setup-macos/action.yml | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/.github/actions/setup-macos/action.yml
> b/.github/actions/setup-macos/action.yml
> > index 91632648..9e752a70 100644
> > --- a/.github/actions/setup-macos/action.yml
> > +++ b/.github/actions/setup-macos/action.yml
> 
> <snipped>
> 
> >
> 
> --
> Best regards,
> Sergey Kaplun
> 

--
Best regards,
Evgeniy Temirgaleev

[-- Attachment #2: Type: text/html, Size: 3415 bytes --]