Re: [Tarantool-patches] [PATCHv2 0/2] lua: fix tarantool -e always enters interactive mode

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for the patches!

LGTM

On 18.02.2021 22:30, Artem Starshov wrote:
> Issue: https://github.com/tarantool/tarantool/issues/5040
> Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug
> CI: https://github.com/tarantool/tarantool/runs/1929677579
>
> Previous patch version: https://lists.tarantool.org/pipermail/tarantool-patches/2021-January/022144.html
>
> Changes in v2:
>    * core:
>      - added `part of #5040` to the commit message;
>      - rename `errinj_scan_env()` -> `errinj_set_with_environment_vars()`;
>      - whitespaces refactored;
>      - add test for setting error injections via environment variables;
>    * lua:
>      - little code refactoring after Sergey Bronnikov review (renames and move
>      includes in the alphabetical order);
>      - fixed bug, when test failed under high concurrency. There were about 20
>      fails with 100 workers. Now, it's ok, tested with 300 workers om CentOS and
>      macOS.
>      (Bug resolved with removing temporary output_file after each testcase iteration);
>      - moved ChangeLog to the last commit.
>
> Artem Starshov (2):
>    core: add setting error injections via env
>    lua: fix tarantool -e always enters interactive mode
>
>   src/lib/core/errinj.c                         |  26 ++++
>   src/lib/core/errinj.h                         |   6 +
>   src/lua/init.c                                |  20 ++-
>   src/main.cc                                   |   1 +
>   ...40-always-enters-interactive-mode.test.lua | 131 ++++++++++++++++++
>   .../errinj_set_with_enviroment_vars.test.lua  |  14 ++
>   ...errinj_set_with_enviroment_vars_script.lua |  13 ++
>   test/box/errinj.result                        |   1 +
>   8 files changed, 208 insertions(+), 4 deletions(-)
>   create mode 100755 test/app-tap/gh-5040-always-enters-interactive-mode.test.lua
>   create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua
>   create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua
>