From: Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Artem <artemreyt@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>,
Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCHv2 2/2] lua: fix tarantool -e always enters interactive mode
Date: Wed, 3 Mar 2021 15:55:37 +0300 [thread overview]
Message-ID: <0def34de-b4da-8903-fd14-2e23c35ef1a9@tarantool.org> (raw)
In-Reply-To: <73fdad5e-f886-56cd-4dde-65214b8a58c6@tarantool.org>
Hi!
Please add the hunks of diff or send a new patchset, because "Done" is a
good, but not detailed enough.(For the future)
>> +
>> +local test = tap.test('gh-5040')
>> +
>> +if not is_debug then
>>
>> Comment:
>> AFAIU `release_disabled` from "suite.ini" is used for this purpose.
>
> 3. Unfortunately, in app-tap directory this option doesn't work.
>
> https://github.com/tarantool/test-run/issues/199
>
After discussion at the standup, it was decided to fix the bug in the
test-run and then return to this task.
next prev parent reply other threads:[~2021-03-03 12:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 19:30 [Tarantool-patches] [PATCHv2 0/2] " Artem Starshov via Tarantool-patches
2021-02-18 19:30 ` [Tarantool-patches] [PATCHv2 1/2] core: add setting error injections via env Artem Starshov via Tarantool-patches
2021-02-20 9:03 ` Sergey Bronnikov via Tarantool-patches
2021-02-20 11:21 ` Artem via Tarantool-patches
2021-02-20 14:27 ` Sergey Bronnikov via Tarantool-patches
2021-02-24 9:38 ` Artem via Tarantool-patches
2021-02-25 14:36 ` Sergey Bronnikov via Tarantool-patches
2021-03-01 14:47 ` Leonid Vasiliev via Tarantool-patches
2021-03-02 17:00 ` Artem via Tarantool-patches
2021-02-18 19:30 ` [Tarantool-patches] [PATCHv2 2/2] lua: fix tarantool -e always enters interactive mode Artem Starshov via Tarantool-patches
2021-02-19 9:15 ` Konstantin Osipov via Tarantool-patches
2021-02-19 14:33 ` Artem via Tarantool-patches
2021-02-20 10:05 ` Sergey Bronnikov via Tarantool-patches
2021-02-20 11:27 ` Artem via Tarantool-patches
2021-03-01 15:10 ` Leonid Vasiliev via Tarantool-patches
2021-03-02 17:05 ` Artem via Tarantool-patches
2021-03-03 12:55 ` Leonid Vasiliev via Tarantool-patches [this message]
2021-02-25 14:37 ` [Tarantool-patches] [PATCHv2 0/2] " Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0def34de-b4da-8903-fd14-2e23c35ef1a9@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=artemreyt@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCHv2 2/2] lua: fix tarantool -e always enters interactive mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox