From: Artem Starshov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Alexander Turenko <alexander.turenko@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCHv2 0/2] lua: fix tarantool -e always enters interactive mode Date: Thu, 18 Feb 2021 22:30:17 +0300 [thread overview] Message-ID: <cover.1613674486.git.artemreyt@tarantool.org> (raw) Issue: https://github.com/tarantool/tarantool/issues/5040 Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug CI: https://github.com/tarantool/tarantool/runs/1929677579 Previous patch version: https://lists.tarantool.org/pipermail/tarantool-patches/2021-January/022144.html Changes in v2: * core: - added `part of #5040` to the commit message; - rename `errinj_scan_env()` -> `errinj_set_with_environment_vars()`; - whitespaces refactored; - add test for setting error injections via environment variables; * lua: - little code refactoring after Sergey Bronnikov review (renames and move includes in the alphabetical order); - fixed bug, when test failed under high concurrency. There were about 20 fails with 100 workers. Now, it's ok, tested with 300 workers om CentOS and macOS. (Bug resolved with removing temporary output_file after each testcase iteration); - moved ChangeLog to the last commit. Artem Starshov (2): core: add setting error injections via env lua: fix tarantool -e always enters interactive mode src/lib/core/errinj.c | 26 ++++ src/lib/core/errinj.h | 6 + src/lua/init.c | 20 ++- src/main.cc | 1 + ...40-always-enters-interactive-mode.test.lua | 131 ++++++++++++++++++ .../errinj_set_with_enviroment_vars.test.lua | 14 ++ ...errinj_set_with_enviroment_vars_script.lua | 13 ++ test/box/errinj.result | 1 + 8 files changed, 208 insertions(+), 4 deletions(-) create mode 100755 test/app-tap/gh-5040-always-enters-interactive-mode.test.lua create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua -- 2.28.0
next reply other threads:[~2021-02-18 19:30 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-18 19:30 Artem Starshov via Tarantool-patches [this message] 2021-02-18 19:30 ` [Tarantool-patches] [PATCHv2 1/2] core: add setting error injections via env Artem Starshov via Tarantool-patches 2021-02-20 9:03 ` Sergey Bronnikov via Tarantool-patches 2021-02-20 11:21 ` Artem via Tarantool-patches 2021-02-20 14:27 ` Sergey Bronnikov via Tarantool-patches 2021-02-24 9:38 ` Artem via Tarantool-patches 2021-02-25 14:36 ` Sergey Bronnikov via Tarantool-patches 2021-03-01 14:47 ` Leonid Vasiliev via Tarantool-patches 2021-03-02 17:00 ` Artem via Tarantool-patches 2021-02-18 19:30 ` [Tarantool-patches] [PATCHv2 2/2] lua: fix tarantool -e always enters interactive mode Artem Starshov via Tarantool-patches 2021-02-19 9:15 ` Konstantin Osipov via Tarantool-patches 2021-02-19 14:33 ` Artem via Tarantool-patches 2021-02-20 10:05 ` Sergey Bronnikov via Tarantool-patches 2021-02-20 11:27 ` Artem via Tarantool-patches 2021-03-01 15:10 ` Leonid Vasiliev via Tarantool-patches 2021-03-02 17:05 ` Artem via Tarantool-patches 2021-03-03 12:55 ` Leonid Vasiliev via Tarantool-patches 2021-02-25 14:37 ` [Tarantool-patches] [PATCHv2 0/2] " Sergey Bronnikov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1613674486.git.artemreyt@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=artemreyt@tarantool.org \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCHv2 0/2] lua: fix tarantool -e always enters interactive mode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox